-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix - Changes for VAMC field in Supporting Evidence #58745
Bug Fix - Changes for VAMC field in Supporting Evidence #58745
Comments
@lydiahooper - do we need a separate ticket for content? |
@RakshindaAslam Nope, there is no IA change, and very minimal content change. |
Seth - Could be some backend validation on this: https://github.com/department-of-veterans-affairs/vets-json-schema/blob/76083e33f175fb00392e31f1f5f90654d05f1fd2/dist/21-526EZ-ALLCLAIMS-schema.json#L1016 |
ICN potentially related to this issue https://dsva.slack.com/archives/C04KW0B46N5/p1686151435447459?thread_ts=1686148130.634419&cid=C04KW0B46N5 |
@lydiahooper : There is a 'Summary of evidence' page that lists out the facilities that were filled out. Is it safe to assume that we should skip this page if user does not fill out a facility name? cc @sethdarragile6 |
@christinec-fftc Good question - I think we can keep this summary page, as users may still list VAMCs (even if those named are not validated) |
@lydiahooper Oh, I should clarify. This is for the scenario when a facility name is not specified. This is what it now looks like this when that happens (an empty bullet for each group) |
@christinec-fftc Right. I think the scenario in which it would be empty would be rare, because it would only happen if the user decides they don't want to provide any info about VAMCs at all. Would it be possible in this instance to simply display next to the bullet the phrase "facility name not provided"? We definitely don't want to skip this page as it summarizes all the actions taken in this section of the form. The language on the page before they enter VAMC info is admittedly confusing, and the design ticket I'm working on this sprint will improve that--I will make sure I look at whether we need to add this to that redesign ticket as well, so thanks for mentioning! |
Sure thing! Yes we can put some default text. |
@lydiahooper With @sethdarragile6's help we found out that country, treatment center name and treated disability names are all required fields for evss api. We cannot make these fields optional without the evss dev team making a corresponding change as this would cause claims submission failures. (slack thread) If we'd still like to proceed with making the fields optional, we'll need to make a request with the evss team (unless this is code we're allowed to change??) In the meantime, we may be able to do a short term fix for this bug by continuing with the content changes and removing autosuggest from the treatment center name. What do you think? |
@christinec-fftc I confirmed that the business agreed that the 3 fields are not required to adjudicate claims, and it looks like EVSS and Lighthouse will relax the validation rules. |
@lydiahooper It sounds like evss changes won't be available until 7/12 in prod. do we want to wait on this story until then or proceed with short term fix (remove autosuggest) and create another story to make the fields optional next month? |
@christinec-fftc let's do what we can for now, thanks! |
Met with @lydiahooper today for approval. Current changes look good. Created #60578 to make the 3 fields optional once EVSS is ready. |
Issue Description
The scope of this ticket is to make the following changes around the VAMC field in Supporting Evidence page:
Need to know
Look at backend validation on this: https://github.com/department-of-veterans-affairs/vets-json-schema/blob/76083e33f175fb00392e31f1f5f90654d05f1fd2/dist/21-526EZ-ALLCLAIMS-schema.json#L1016
https://www.sketch.com/s/5e464026-9acb-4f80-a4f9-634c7e972d19
This is based on our discussion with VBA stakeholders(Alejandro) on May 18th
Remove requirement of entering VAMC name on the evidence screen
We propose to either remove this field altogether or at least making it optional so the user does not see this issue.
Update 6/15/23
We found out that these newly optional fields are required in EVSS (slack thread) For now, we will move forward with only the content changes and removing auto suggest from the facilities name field. That should hopefully allow users to proceed.
AC has been updated accordingly and we will file a subsequent story to be worked on next month, once the 3 fields are optional in EVSS.
Tasks
Backend testsAcceptance Criteria
User will be able to enter a Country, Condition without validationUser will be able to submit the claim without entering any value for VAMC, Country, ConditionHow to configure this issue
product support
,analytics-insights
,operations
,service-design
,Console-Services
,tools-fe
)backend
,frontend
,devops
,design
,research
,product
,ia
,qa
,analytics
,contact center
,research
,accessibility
,content
)bug
,request
,discovery
,documentation
, etc.)The text was updated successfully, but these errors were encountered: