Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

58745 VAMC optional fields #12996

Closed
wants to merge 0 commits into from
Closed

Conversation

sethdarragile6
Copy link
Contributor

Summary

  • Update reference to vets-json-schema (once that PR has been merged
  • Schema changes (in a nutshell): make the treatment center name, disabilities names and country fields optional
  • IMPORTANT: once vets-json-schema is merged, a new commit with the updated reference must be pushed to this PR. Then, it will be taken out of Draft mode. DO NOT MERGE UNTIL THEN
  • Owners: dbex-trex (Disability Benefits Experience Team 1)

Related issue(s)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@sethdarragile6 sethdarragile6 added the disability-experience To manage benefits disability claims experience. label Jun 14, 2023
@sethdarragile6 sethdarragile6 self-assigned this Jun 14, 2023
@sethdarragile6 sethdarragile6 requested review from a team as code owners June 14, 2023 17:28
@sethdarragile6 sethdarragile6 marked this pull request as draft June 14, 2023 17:33
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/58745-vamc-optional/main/main June 14, 2023 17:33 Inactive
@christinec-fftc christinec-fftc added the NOT_YET Don't merge this PR w/o the authors permission label Jun 15, 2023
@christinec-fftc
Copy link
Contributor

We discovered that these newly optional fields are required in EVSS. Do not proceed with this PR until after EVSS has made corresponding changes. Currently scheduled for 7/12/23.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 15, 2023
@github-actions
Copy link

This PR has been closed because it has had no activity for 37 days

@github-actions github-actions bot closed this Jul 22, 2023
@github-actions github-actions bot deleted the dbex/58745-vamc-optional branch July 22, 2023 23:32
@sethdarragile6 sethdarragile6 restored the dbex/58745-vamc-optional branch July 24, 2023 15:59
@va-vsp-bot va-vsp-bot requested a deployment to dbex/58745-vamc-optional/main/main July 24, 2023 15:59 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/58745-vamc-optional/main/main July 24, 2023 16:00 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to dbex/58745-vamc-optional/main/main July 24, 2023 16:06 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/58745-vamc-optional/main/main July 24, 2023 16:12 Inactive
@github-actions github-actions bot removed the Stale label Jul 24, 2023
@va-vsp-bot va-vsp-bot requested a deployment to dbex/58745-vamc-optional/main/main July 25, 2023 22:15 In progress
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 24, 2023
@github-actions
Copy link

This PR has been closed because it has had no activity for 37 days

@github-actions github-actions bot closed this Aug 31, 2023
@github-actions github-actions bot deleted the dbex/58745-vamc-optional branch August 31, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console-services-review disability-experience To manage benefits disability claims experience. NOT_YET Don't merge this PR w/o the authors permission Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants