Make VAMC fields optional

[christinec-fftc]

Pending the BE discovery ticket on optional fields for VAMC

Issue Description

Follow up from #58745

We discovered that we had to wait for EVSS to make the 3 fields optional - treatment center name, disability names, country. This ticket should be worked on after we get confirmation those changes are complete.

ETA - July 12th - Confirm with eVSS. Also check on LH api before proceeding. - Confirmed

Front end tasks

• Ensure the page is styled according to design spec.
• Ensure the back end data from API is displayed in local and review instance
• Ensure unit tests are available.
• Ensure your code changes are covered by E2E tests
• Run axe checks using the Chrome or Firefox browser plugin
• Test for color contrast and color blindness issues
• Zoom layouts to 400% at 1280px width
• Test with 1 or 2 screen readers
• Navigate using the keyboard only

Back-end Tasks

• In data_translation_all_claim.rb:458 we need a safe navigator (treatment['treatmentCenterName']&.gsub...) so that the ruby code will not error out if the center name is null/nil
• Update vets-json-schema, then vets-website and vets-api with new schema
• Run E2E test following Emily's instructions
• [Need confirmation that this is desired outcome] Test on Staging that submission is successful whether or not treatedDisabilityNames is null. (Currently in LH, "the treatedDisabilityNames cannot be null, but we have tested with the other related attributes set to null.")

Acceptance Criteria

• On the va-medical-records page, make these 3 fields optional: treatment center name, disability names, country
• Designer comments on this issue to approve page styling
• Unit tests pass
• E2E tests cover current code and regression
• End-to-end tests show 0 violations.
• The data returned matches API response (for given user or scenario)
• All axe checks pass
• All color contrast checks pass
• All zoom testing passes
• All keyboard checks pass
• All screenreader checks pass

Appendix

Ensure your code changes are covered by E2E tests (expand)

• Add E2E tests if none exist for this addition/change.

• Update existing E2E tests if this code will change functionality.

• Include axe checks, including hidden content

Run axe checks using the Chrome or Firefox browser plugin (expand)

• Ensure no heading levels are skipped.

• Ensure all buttons and labeled inputs use semantic HTML elements.

• Ensure all buttons, labeled elements and images are identified using HTML semantic markers or ARIA roles.

• Ensure form fields have clearly defined boundaries or outlines.

• Ensure form fields do not use placeholder text.

• Ensure form fields have highly visible and specific error states.

Test for color contrast and color blindness issues (expand)

- All text has appropriate contrast.

Zoom layouts to 400% at 1280px width (expand)

- Ensure readability and usability are supported when zoomed up to 400% at 1280px browser width - Ensure no content gets focused offscreen or is hidden from view.

Test with 1 or 2 screen readers (expand)

• Ensure the page includes a skip navigation link.

• Ensure all links are properly descriptive.

• Ensure screen reader users can hear the text equivalent for each image conveying information.

• Ensure screen reader users can hear the text equivalent for each image button.

• Ensure screen reader users can hear labels and instructions for inputs.

• Ensure purely decorative images are not announced by the screenreader.

Navigate using the keyboard only (expand)

• Ensure all links (navigation, text and/or image), form controls and page functions can be reached with the tab key in a logical order.

• Ensure all links (navigation, text and/or image), form controls and page functions can be triggered with the spacebar, enter key, or arrow keys.

• Ensure all interactive elements can be reached with the tab key in a logical order

• Ensure all interactive elements can be triggered with the spacebar, enter key, or arrow keys.

• Ensure focus is always visible and appears in logical order.

• Ensure each interactive element has visible focus state which appears in logical order.

---

How to configure this issue

• Attached to a Milestone (when will this be completed?)
• Attached to an Epic (what body of work is this a part of?)
• Labeled with Team (product support, analytics-insights, operations, service-design, Console-Services, tools-fe)
• Labeled with Practice Area (backend, frontend, devops, design, research, product, ia, qa, analytics, contact center, research, accessibility, content)
• Labeled with Type (bug, request, discovery, documentation, etc.)

[RakshindaAslam]

@christinec-fftc - do we have a slack thread to check for evss update on this?

[christinec-fftc]

@RakshindaAslam yes, it's linked in the previous ticket, but here's also a link that notes the changes were deployed 7/12/23

[RakshindaAslam]

@RakshindaAslam - check downstream ticket for Lighthouse

[christinec-fftc]

@RakshindaAslam Product Guide has been updated to v2.1

[christinec-fftc]

We discovered a couple issues while testing. Although the updated va-medical-records page is working as expected with the new optional fields, the review and submit page is failing. Couple issues here

1. the VA Treatment Center Address is using a standard city format which says that a city field cannot be empty. We can work around this by making another json schema change to add a custom city validation and allow an empty string
2. vets-api: it's unclear how to uptake the schema changes locally to test the changes. also, beyond the schema changes, it looks like there may be additional code changes to make the 3 fields optional. we'll be opening another discovery ticket to look into the back end changes
   cc @sethdarragile6

[christinec-fftc]

#62546 was created for BE discovery. Moving this ticket to the backlog for now and rolled back the product guide changes cc @RakshindaAslam

[pacerwow]

@christinec-fftc can this be closed?

[christinec-fftc]

@pacerwow Similar to the other ticket, we should not unnecessarily make fields required. Would need a little discovery to see if LH changes are working as expected before proceeding with our changes.