Rename font-size-base to font-size-root, add source-sans-normalized with associated utility class #3511
Conversation
…ith associated utility class
powellkerry
temporarily deployed
to
development
GitHub Actions
Inactive
powellkerry
temporarily deployed
to
development
GitHub Actions
Inactive
config/gulp/css.js
Outdated
| gulp.task('copy-css-library', function (done) { | ||
| console.log('copying web-components CSS'); | ||
| var stream = gulp.src('./node_modules/@department-of-veterans-affairs/css-library/dist/stylesheets/*.css') | ||
| .pipe(gulp.dest('src/assets/stylesheets/')); | ||
|
|
||
| return stream; | ||
| }); | ||
|
|
There was a problem hiding this comment.
I don't understand why this is needed, could you explain? 🙏
There was a problem hiding this comment.
This is to copy stylesheets into the documentation site from css-library. This is the way that it is done for both formation and web-components. This allows the utilites.css file to be included in the head so that the /foundation/utilities/font-size page will render the correct styles using the utility classes.
Currently on this page, none of the font-families are being applied. This is why I wanted to get a patch in before we take on the larger effort of replacing formation on the entire site.
Co-authored-by: Micah Chiang <[email protected]>
powellkerry
temporarily deployed
to
development
GitHub Actions
Inactive
Co-authored-by: Micah Chiang <[email protected]>
powellkerry
temporarily deployed
to
development
GitHub Actions
Inactive
powellkerry
temporarily deployed
to
development
GitHub Actions
Inactive
powellkerry
temporarily deployed
to
development
GitHub Actions
Inactive
powellkerry
temporarily deployed
to
development
GitHub Actions
Inactive
powellkerry
had a problem deploying
to
development
GitHub Actions
Failure
powellkerry
had a problem deploying
to
development
GitHub Actions
Failure
powellkerry
had a problem deploying
to
development
GitHub Actions
Failure
powellkerry
temporarily deployed
to
development
GitHub Actions
Inactive
| gulp.task('copy-css-library-css', function (done) { | ||
| console.log('copying css-library CSS'); | ||
| var stream = gulp.src('./node_modules/@department-of-veterans-affairs/css-library/dist/stylesheets/*.css') | ||
| .pipe(gulp.dest('src/assets/stylesheets/')); | ||
|
|
||
| return stream; | ||
| }); | ||
|
|
There was a problem hiding this comment.
Is this needed to actually get css-library styles working on the doc site?
There was a problem hiding this comment.
This is needed to load stylesheets from the css-library on the docs site, currently we are only adding the utilities.css file. We may want to investigate if there is a better solution when we remove formation. Seems like there should be a better way to use module stylesheets in jekyll html templates.
Update font tokens and utilities classes
see 3452
Changes:
font-size-basetofont-size-root(1rem/16px)vads-font-size-source-sans-normalizedtoken (1.063rem/16.96px).vads-u-font-size--source-sans-normalizedutility class* In draft mode until css-library release, styles on the utilities page will not be displayed correctly until then.
css-library PR: department-of-veterans-affairs/component-library#1399