-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css-library: add source-sans normalize token, rename base to root #1399
Conversation
@@ -135,6 +135,8 @@ | |||
--vads-font-line-height-body-lead: 1.75; | |||
--vads-font-line-height-default: 1.5; | |||
--vads-font-line-height-heading: 1.2; | |||
--vads-font-size-source-sans-normalized: 1.06rem; | |||
--vads-font-size-root: 1rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@powellkerry @micahchiang If we're renaming font-size-base
to font-size-root
, then anywhere we use this token will need to be updated for the name change. If that's the case, why wouldn't we point to the newly added vads-font-size-root
instead? They both have the same value/meaning, right? What are the reasons we need to have both these tokens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about that but thought I would leave it until someone validated my thoughts :) The --vads--font-size-root should be removed now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@powellkerry @danbrady - I added a comment below. We can keep the css custom property that gets generated - font-size-root
- because the original, font-size-base
, wasn't being used anywhere in vets-website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes to just the src/tokens/fonts.scss file so utility classes remain the same.
'sm': $font-size-sm, | ||
'base': $font-size-base, | ||
'root': $font-size-root, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, you can keep this as base with the updated value so the utility class remains the same.
'root': $font-size-root, | |
'base': $font-size-root, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did update this on the documentation site PR. Should we keep root and base or should I revert that change on the documentation site PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments on your doc site PR. I think some of the changes need to be reverted for the utility class updates there, and some changes need to be modified because we're not actually generating a vads-font-size-root
token, just a token named font-size-root
@@ -43,6 +43,7 @@ | |||
"heading": { "value": "1.2" } | |||
}, | |||
"size": { | |||
"source-sans-normalized": { "value": "1.06rem" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@powellkerry I looked back at our original slack conversation.
Currently in this PR we're just generating a font-size-root
token, given your changes above on line 21. If we want to additionally add a vads-font-size-root
token, then another entry needs to be added here in the vads-font.size
object, similar to what you've added above for source-sans-normalized
. Adding a "root": {"value": "1rem"}
entry here should generate a token named vads-font-size-root
.
Chromatic
https://3452-update-font-tokens--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
vads-u-font-size--source-sans-normalized
Documentation site PR: department-of-veterans-affairs/vets-design-system-documentation#3511
Closes 3452
QA Checklist
Screenshots
Acceptance criteria
Definition of done