99889 [Bug] Debt Team 5655 is mis-categorizing some forms

[digitaldrk]

Summary

• This work is behind a feature toggle (flipper): YES/NO: NO
• (Summarize the changes that have been made to the platform): We have a bug where some of our forms are marked as 'streamlined' when they shouldn't be. This small change remedies this issue.
• (If bug, how to reproduce): We pulled the errored form data, verified the issue, made our fix, and verified proper output
• (What is the solution, why is this the solution?): We simplified the logic to account for a method that was encapsulating a feature flag from the FE. This helps us properly determine streamlined forms.
• (Which team do you work for, does your team own the maintenance of this component?): Debt resolution. You can find me on #debt-resolution on the Octo slack
• (If introducing a flipper, what is the success criteria being targeted?): N/A

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira:
  [FSR] Bug - Submission is being improperly categorized va.gov-team#99889
• Link to previous change of the code/bug (if applicable): N/A
• Link to epic if not included in ticket

Testing done

• New code is covered by unit tests
• Describe what the old behavior was prior to the change: Vets with a higher income were being flagged as streamlined.
• Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing: We pulled an example form from the DB and ran it through the service before and after to verify it was working.
• If this work is behind a flipper:: No
  • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
  • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas): N/A

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[penny-lischer]

LGTM

[Dr-Pongo]

LGTM! 🚀

[Dr-Pongo]

LGTM! 🚀