Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEBT-998: 1995 spool file - first ssn at top should never be blank, add tests #20168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+778 −38
Open

VEBT-998: 1995 spool file - first ssn at top should never be blank, add tests #20168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/sidekiq/education_form/templates/header_1995.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@
<%= applicant_name&.first&.upcase&.strip %>
<%= applicant_name&.middle&.upcase&.strip %>
<%= applicant_name&.last&.upcase&.strip %>
<% if @applicant.benefitAppliedFor.eql?('chapter35') || (@applicant.benefitAppliedFor.blank? && @applicant.benefitUpdate.eql?('chapter35')) -%>
<%= @applicant.sponsorSocialSecurityNumber&.gsub(/[^\d]/, '') %>
<% else -%>
<%= @applicant.veteranSocialSecurityNumber&.gsub(/[^\d]/, '') %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like lines 8 and 10 are the same @applicant.veteranSocialSecurityNumber&.gsub(/[^\d]/, '')

Is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lindsey, yes, that is intentional, we are supposed to show the same veteran ssn twice in many cases. Thanks.

<% end -%>
<%= @applicant.veteranSocialSecurityNumber&.gsub(/[^\d]/, '') %>
<%= header_form_type %>

Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/education_benefits_claims/1995/ch1606.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
"first": "Joe",
"last": "Tester2"
},
"veteranSocialSecurityNumber": "334445555",
"veteranSocialSecurityNumber": "223334444",
"veteranAddress": {
"city": "Austin",
"country": "USA",
"postalCode": "73301",
"state": "TX",
"street": "1234 Test St"
},
"sponsorSocialSecurityNumber": "334445555",
"sponsorSocialSecurityNumber": "444433322",
"applicantGender": "F",
"dateOfBirth": "1970-01-01",
"email": "[email protected]",
Expand Down
6 changes: 3 additions & 3 deletions spec/fixtures/education_benefits_claims/1995/ch1606.spl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
JOE

TESTER2
334445555
334445555
223334444
223334444
1995R


Expand All @@ -20,7 +20,7 @@ FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE
APPLICANT INFORMATION
---------------------

SSN: 334445555 VA File Number: N/A
SSN: 223334444 VA File Number: N/A

Sex: F Date of Birth: 1970-01-01

Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/education_benefits_claims/1995/ch30.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"street": "123 Test St"
},
"applicantServed": "No",
"sponsorSocialSecurityNumber": "223334444",
"sponsorSocialSecurityNumber": "444433322",
"applicantGender": "F",
"dateOfBirth": "1970-01-01",
"email": "[email protected]",
Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/education_benefits_claims/1995/ch30_guardian_graduated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"state": "TX",
"street": "123 Test St"
},
"sponsorSocialSecurityNumber": "223334444",
"sponsorSocialSecurityNumber": "444433322",
"vaFileNumber": "c12345679",
"applicantGender": "F",
"dateOfBirth": "1970-01-01",
Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/education_benefits_claims/1995/ch30_guardian_graduated_sponsor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"state": "TX",
"street": "123 Test St"
},
"sponsorSocialSecurityNumber": "123456789",
"sponsorSocialSecurityNumber": "444433322",
"sponsorFullName": {
"first": "John",
"last": "Smith"
Expand All @@ -36,7 +36,7 @@
"guardianFirstName":"Richard",
"guardianMiddleName":"D",
"guardianLastName":"Van Dyke",
"guardianSuffix":"Jr.",
"guardianSuffix":"Jr.",
"guardianAddress":{
"street":"456 oak blvd",
"street2":"apt 88",
Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/education_benefits_claims/1995/ch30_guardian_graduated_sponsor.spl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
JOE

TESTER
123456789
444433322
223334444
1995R

Expand Down Expand Up @@ -49,7 +49,7 @@ Routing/Transit #: Account #:

Name: John Smith

SSN: 123456789
SSN: 444433322

VA File Number: c12345679

Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/education_benefits_claims/1995/ch30_guardian_not_graduated.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"state": "TX",
"street": "123 Test St"
},
"sponsorSocialSecurityNumber": "223334444",
"sponsorSocialSecurityNumber": "444433322",
"applicantGender": "F",
"dateOfBirth": "1970-01-01",
"email": "[email protected]",
Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/education_benefits_claims/1995/ch33_fry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"middle": "middle",
"last": "last"
},
"veteranSocialSecurityNumber": "111223333",
"veteranSocialSecurityNumber": "223334444",
"newSchool": {
"name": "school name",
"address": {
Expand Down Expand Up @@ -38,7 +38,7 @@
"state": "WI",
"street": "123 Main St"
},
"sponsorSocialSecurityNumber": "111223333",
"sponsorSocialSecurityNumber": "444433322",
"applicantGender": "F",
"dateOfBirth": "1970-01-01",
"civilianBenefitsAssistance": true,
Expand Down
6 changes: 3 additions & 3 deletions spec/fixtures/education_benefits_claims/1995/ch33_fry.spl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
FIRST
MIDDLE
LAST
111223333
111223333
223334444
223334444
1995R

SCHOOL NAME
Expand All @@ -20,7 +20,7 @@ FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE
APPLICANT INFORMATION
---------------------

SSN: 111223333 VA File Number: c12345678
SSN: 223334444 VA File Number: c12345678

Sex: F Date of Birth: 1970-01-01

Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/education_benefits_claims/1995/ch33_fry_noncollege.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"middle": "middle",
"last": "last"
},
"veteranSocialSecurityNumber": "111223333",
"veteranSocialSecurityNumber": "223334444",
"newSchool": {
"name": "school name",
"address": {
Expand Down Expand Up @@ -38,7 +38,7 @@
"state": "WI",
"street": "123 Main St"
},
"sponsorSocialSecurityNumber": "111223333",
"sponsorSocialSecurityNumber": "444433322",
"applicantGender": "F",
"dateOfBirth": "1970-01-01",
"civilianBenefitsAssistance": true,
Expand Down
6 changes: 3 additions & 3 deletions spec/fixtures/education_benefits_claims/1995/ch33_fry_noncollege.spl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
FIRST
MIDDLE
LAST
111223333
111223333
223334444
223334444
1995R

SCHOOL NAME
Expand All @@ -20,7 +20,7 @@ FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE
APPLICANT INFORMATION
---------------------

SSN: 111223333 VA File Number: c12345678
SSN: 223334444 VA File Number: c12345678

Sex: F Date of Birth: 1970-01-01

Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/education_benefits_claims/1995/ch33_post911.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"middle": "middle",
"last": "last"
},
"veteranSocialSecurityNumber": "111223333",
"veteranSocialSecurityNumber": "223334444",
"newSchool": {
"name": "school name",
"address": {
Expand All @@ -15,7 +15,7 @@
"street": "111 Uni Drive"
}
},
"sponsorSocialSecurityNumber": "111223333",
"sponsorSocialSecurityNumber": "444433322",
"oldSchool": {
"name": "old school name",
"address": {
Expand Down
6 changes: 3 additions & 3 deletions spec/fixtures/education_benefits_claims/1995/ch33_post911.spl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
FIRST
MIDDLE
LAST
111223333
111223333
223334444
223334444
1995R

SCHOOL NAME
Expand All @@ -20,7 +20,7 @@ FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE
APPLICANT INFORMATION
---------------------

SSN: 111223333 VA File Number: c12345678
SSN: 223334444 VA File Number: c12345678

Sex: F Date of Birth: 1970-01-01

Expand Down
12 changes: 8 additions & 4 deletions spec/fixtures/education_benefits_claims/1995/kitchen_sink.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"middle": "middle",
"last": "last"
},
"veteranSocialSecurityNumber": "111223333",
"veteranSocialSecurityNumber": "223334444",
"newSchool": {
"name": "school name",
"address": {
Expand All @@ -15,7 +15,11 @@
"street": "111 Uni Drive"
}
},
"sponsorSocialSecurityNumber": "111223333",
"sponsorSocialSecurityNumber": "444433322",
"sponsorFullName": {
"first": "John",
"last": "Smith"
},
"oldSchool": {
"name": "old school name",
"address": {
Expand All @@ -29,7 +33,7 @@
"preferredContactMethod": "email",
"trainingEndDate": "2007-06-XX",
"reasonForChange": "reason for change",
"vaFileNumber": "c12345678",
"vaFileNumber": "c12345679",
"homePhone": "5551110000",
"mobilePhone": "5551110001",
"veteranAddress": {
Expand All @@ -47,7 +51,7 @@
"benefitUpdate": "transferOfEntitlement",
"rudisillReview": "No",
"changeAnotherBenefit": "Yes",
"benefitAppliedFor": "chapter30",
"benefitAppliedFor": "chapter35",
"educationType": "tuitionTopUp",
"educationTypeUpdate": "prepCourseForLoC",
"educationObjective": "bachelor's degree",
Expand Down
19 changes: 14 additions & 5 deletions spec/fixtures/education_benefits_claims/1995/kitchen_sink.spl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
FIRST
MIDDLE
LAST
111223333
111223333
444433322
223334444
V1995

SCHOOL NAME
Chapter30
Chapter35
*START*
VA Form 22-1995
OMB Control #: 2900-0074
Expand All @@ -20,7 +20,7 @@ FOR VETERANS, SERVICEPERSONS, DEPENDENTS & MEMBERS OF THE SELECTED RESERVE
APPLICANT INFORMATION
---------------------

SSN: 111223333 VA File Number: c12345678
SSN: 223334444 VA File Number: c12345679

Sex: F Date of Birth: 1970-01-01

Expand All @@ -41,6 +41,15 @@ Direct Deposit: Start or Update EFT
Type of Account: checking
Routing/Transit #: 123456789 Account #: 88888888888

DEA, CH35 SPONSOR/SERVICE MEMBER INFORMATION
--------------------------------------------

Name: John Smith

SSN: 444433322

VA File Number: c12345679

TYPE AND PROGRAM OF EDUCATION OR TRAINING
-----------------------------------------

Expand All @@ -50,7 +59,7 @@ Do you wish to request a 'Rudisill' review?: No

Select Another Benefit: Yes

Benefit Being Applied For: Chapter30
Benefit Being Applied For: Chapter35

Type of Education or Training: Prep Course For Lo C
Education or Career Goal: bachelor's degree
Expand Down
Loading
Loading