Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEBT-998: 1995 spool file - first ssn at top should never be blank, add tests #20168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GcioGregg
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • VEBT-998: 1995 spool file - first ssn at top should never be blank, add tests
  • (If bug, how to reproduce) N/A
  • add logic for non chapter 35 to always show ssn
  • VEBT
  • (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

Testing done

  • New code is covered by unit tests
  • sometimes first ssn at top of spool file was blank, should always be filled in
  • submit a 1995 form and check resulting spool file

What areas of the site does it impact?

1995 spool file

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

<%= @applicant.sponsorSocialSecurityNumber&.gsub(/[^\d]/, '') %>
<% else -%>
<%= @applicant.veteranSocialSecurityNumber&.gsub(/[^\d]/, '') %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like lines 8 and 10 are the same @applicant.veteranSocialSecurityNumber&.gsub(/[^\d]/, '')

Is this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants