Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE | Ask VA Api: Fix bug in HealthFacilitiesController#retrieve_patsr_approved_facilities #19984

Merged
merged 1 commit into from
Dec 20, 2024
Merged

BE | Ask VA Api: Fix bug in HealthFacilitiesController#retrieve_patsr_approved_facilities #19984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions modules/ask_va_api/app/controllers/ask_va_api/v0/health_facilities_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def search
end
end

patsr_approved_codes = retrieve_patsr_approved_facilities.pluck(:FacilityCode)
patsr_approved_codes = retrieve_patsr_approved_facilities[:Data].pluck(:FacilityCode)

filtered_results = WillPaginate::Collection.create(
api_results.current_page,
Expand All @@ -42,8 +42,7 @@ def show
private

def retrieve_patsr_approved_facilities
data = Crm::CacheData.new.fetch_and_cache_data(endpoint: 'Facilities', cache_key: 'Facilities', payload: {})
JSON.parse(data, symbolize_names: true)[:Data]
Crm::CacheData.new.fetch_and_cache_data(endpoint: 'Facilities', cache_key: 'Facilities', payload: {})
end

def api
Expand Down
3 changes: 2 additions & 1 deletion modules/ask_va_api/spec/requests/ask_va_api/v0/health_facilities_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@

let(:cache_data_instance) { Crm::CacheData.new }
let(:patsr_facilities) do
File.read('modules/ask_va_api/config/locales/get_facilities_mock_data.json')
data = File.read('modules/ask_va_api/config/locales/get_facilities_mock_data.json')
JSON.parse(data, symbolize_names: true)
end

before do
Expand Down
Loading