Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE | Ask VA Api: Fix bug in HealthFacilitiesController#retrieve_patsr_approved_facilities #19984

Merged
merged 1 commit into from
Dec 20, 2024
Merged

BE | Ask VA Api: Fix bug in HealthFacilitiesController#retrieve_patsr_approved_facilities #19984

merged 1 commit into from
Dec 20, 2024

Conversation

Khoa-V-Nguyen
Copy link
Contributor

Summary

  • Fix bug in HealthFacilitiesController#retrieve_patsr_approved_facilities

Related issue(s)

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@Khoa-V-Nguyen Khoa-V-Nguyen self-assigned this Dec 20, 2024
@Khoa-V-Nguyen Khoa-V-Nguyen requested review from a team as code owners December 20, 2024 19:30
@Khoa-V-Nguyen Khoa-V-Nguyen enabled auto-merge (squash) December 20, 2024 19:33
hemeshvpatel
hemeshvpatel approved these changes Dec 20, 2024
View reviewed changes
Copy link

@hemeshvpatel hemeshvpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Khoa-V-Nguyen Khoa-V-Nguyen merged commit 36a2f78 into master Dec 20, 2024
38 of 39 checks passed
@Khoa-V-Nguyen Khoa-V-Nguyen deleted the ask-va-api-fix-health-facility-bug branch December 20, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemeshvpatel hemeshvpatel hemeshvpatel approved these changes

@ryan-mcneil ryan-mcneil ryan-mcneil approved these changes

Assignees

@Khoa-V-Nguyen Khoa-V-Nguyen

Labels
require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Khoa-V-Nguyen @ryan-mcneil @hemeshvpatel