API-42930-vnp-proc-service-2-standardization #19893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
API-42930-vnp-proc-service-2-standardization/main/main
va-vfs-bot
temporarily deployed
to
API-42930-vnp-proc-service-2-standardization/main/main
va-vfs-bot
temporarily deployed
to
API-42930-vnp-proc-service-2-standardization/main/main
tycol7
reviewed
Dec 19, 2024
| @@ -433,7 +433,7 @@ module VnpProcFormCreate | |||
| module VnpProcWebServiceBeanV2 | |||
| DEFINITION = | |||
| Bean.new( | |||
| path: 'VnpProcWebServiceBeanV2', | |||
| path: 'VnpProcWebServiceBeanV2/VnpProcServiceV2', | |||
There was a problem hiding this comment.
Why are we adding the service to the path here? The other modules only have the Bean in the path. Is this pattern unique to 'Vnp' services?
There was a problem hiding this comment.
yeah, this is actually causing it to call for the WSDL.
There was a problem hiding this comment.
Sounds good! My mistake, I think this comment ☝️ means we want to remove the extra VnpProcServiceV2.
Comment on lines
-214
to
-224
| context 'VnpProcWebServiceBeanV2' do | ||
| let(:endpoint) { 'VnpProcWebServiceBeanV2/VnpProcServiceV2' } | ||
|
|
||
| it 'response with the correct namespace' do | ||
| result = subject.for_service(endpoint) | ||
| parsed_result = JSON.parse(result.to_json) | ||
| expect(parsed_result['bean']['path']).to eq 'VnpProcWebServiceBeanV2' | ||
| expect(parsed_result['path']).to eq 'VnpProcServiceV2' | ||
| expect(parsed_result['bean']['namespaces']['target']).to eq 'http://procService.services.v2.vonapp.vba.va.gov/' | ||
| end | ||
| end |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria