API-42929-vnp-proc-form-service-standardization

[stiehlrod]

Summary

• Removes extra methods in definitions file,
• rename service, and
• removes extra tests.

Related issue(s)

• API-42308

Testing done

• post '/:veteranId/power-of-attorney-request', to: 'request#create'
• post '/:veteranId/power-of-attorney-request' in staging & checked DD for wdsl call

What areas of the site does it impact?

modified:   modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
modified:   modules/claims_api/spec/lib/claims_api/find_definition_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[tycol7]

Same question as on #19893 - are we only adding the service to the path on Vnp beans?

[tycol7]

Resolved here. My mistake - I think we want to remove VnpProcFormService here.

[tycol7]

Should we keep this test?