Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-42929-vnp-proc-form-service-standardization #19888

Closed
wants to merge 3 commits into from
Closed

API-42929-vnp-proc-form-service-standardization #19888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
845c4e1
Removes extra methods in definitions file, rename service, and remove…
stiehlrod Dec 13, 2024
a14c5a7
Merge branch 'master' into API-42929-vnp-proc-form-service-standardiz…
stiehlrod Dec 17, 2024
72c1c60
Updates definitions file: adds back the service and renames the bean.
stiehlrod Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ module FindPoaByParticipantId
module VnpProcFormWebServiceBean
DEFINITION =
Bean.new(
path: 'VnpProcFormWebServiceBean',
path: 'VnpProcFormWebServiceBean/VnpProcFormService',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as on #19893 - are we only adding the service to the path on Vnp beans?

Copy link
Contributor

@tycol7 tycol7 Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved here. My mistake - I think we want to remove VnpProcFormService here.

namespaces: Namespaces.new(
target: 'http://procFormService.services.vonapp.vba.va.gov/',
data: nil
Expand All @@ -416,15 +416,6 @@ module VnpProcFormService
bean: VnpProcFormWebServiceBean::DEFINITION,
path: 'VnpProcFormService'
)

module VnpProcFormCreate
DEFINITION =
Action.new(
service: VnpProcFormService::DEFINITION,
name: 'vnpProcFormCreate',
key: 'return'
)
end
end

##
Expand Down
26 changes: 0 additions & 26 deletions modules/claims_api/spec/lib/claims_api/find_definition_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,20 +73,6 @@
end
end

context 'VnpProcFormWebServiceBean' do
let(:endpoint) { 'VnpProcFormWebServiceBean/VnpProcFormService' }
let(:action) { 'vnpProcFormCreate' }
let(:key) { 'return' }

it 'response with the correct attributes' do
result = subject.for_action(endpoint, action)
parsed_result = JSON.parse(result.to_json)
expect(parsed_result['service']['bean']['path']).to eq 'VnpProcFormWebServiceBean'
expect(parsed_result['service']['path']).to eq 'VnpProcFormService'
expect(parsed_result['service']['bean']['namespaces']['target']).to eq 'http://procFormService.services.vonapp.vba.va.gov/'
end
end

context 'VnpProcWebServiceBeanV2' do
let(:endpoint) { 'VnpProcWebServiceBeanV2/VnpProcServiceV2' }
let(:action) { 'vnpProcCreate' }
Expand Down Expand Up @@ -199,18 +185,6 @@
end
end

context 'VnpProcFormWebServiceBean' do
let(:endpoint) { 'VnpProcFormWebServiceBean/VnpProcFormService' }

it 'response with the correct namespace' do
result = subject.for_service(endpoint)
parsed_result = JSON.parse(result.to_json)
expect(parsed_result['bean']['path']).to eq 'VnpProcFormWebServiceBean'
expect(parsed_result['path']).to eq 'VnpProcFormService'
expect(parsed_result['bean']['namespaces']['target']).to eq 'http://procFormService.services.vonapp.vba.va.gov/'
end
end
Comment on lines -202 to -212
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this test?


context 'VnpProcWebServiceBeanV2' do
let(:endpoint) { 'VnpProcWebServiceBeanV2/VnpProcServiceV2' }

Expand Down
Loading