Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rails 7.2.2 -> 8.0.0 #19853

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
+303 −189
Draft

Update rails 7.2.2 -> 8.0.0 #19853

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
08c846b
Upgrade to Rail 8
ryan-mcneil Dec 10, 2024
de77aec
temporarily point to rails 8 branch of activerecord-postgis-adapter
ryan-mcneil Dec 10, 2024
302f4b0
fix merge conflict
ryan-mcneil Dec 12, 2024
3bd1261
fix upload_file_spec
ryan-mcneil Dec 12, 2024
0aecb2f
temporarily skip prescriptions_spec
Dec 17, 2024
4b734e9
bump to 8.0.1
Dec 17, 2024
2eb95f9
fix 2122 spec
ryan-mcneil Dec 17, 2024
1c23ce8
add brakeman bin
ryan-mcneil Dec 17, 2024
4e29e61
add rubocop bin
ryan-mcneil Dec 17, 2024
8cd70e9
update puma.rb per rails 8 standard
ryan-mcneil Dec 17, 2024
c43f1a6
update application.rb per rails 8.0 defaults and add rails 7.0,7.1,8.…
ryan-mcneil Dec 17, 2024
749b3f4
update test.rb per rails 8 defaults
ryan-mcneil Dec 17, 2024
706642c
update development.rb to rails 8 defaults
ryan-mcneil Dec 17, 2024
d5f0325
fix config defaults
ryan-mcneil Dec 17, 2024
05d7b0c
comment out autoload config changes for now
ryan-mcneil Dec 19, 2024
f607afd
update production.rb per rails 8 defaults
ryan-mcneil Dec 19, 2024
9d941c1
merge master
ryan-mcneil Jan 2, 2025
1943d84
update dependencies
ryan-mcneil Jan 3, 2025
c230ba3
fix rubocop
ryan-mcneil Jan 3, 2025
6298243
set raise_on_missing_callback_actions back to false for now
ryan-mcneil Jan 3, 2025
43b28e7
Merge branch 'master' into rm-update-rails-8.0
ryan-mcneil Jan 6, 2025
681cb11
codeowners
ryan-mcneil Jan 6, 2025
94c35af
bundle update rails
ryan-mcneil Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ path 'modules' do
gem 'vye'
end

gem 'rails', '~> 7.2.2'
gem 'rails', '~> 8.0.0'

gem 'aasm'
gem 'activerecord-import'
gem 'activerecord-postgis-adapter'
gem 'activerecord-postgis-adapter', github: 'StoneGod/activerecord-postgis-adapter', branch: 'rails-8'
gem 'addressable'
gem 'aws-sdk-kms'
gem 'aws-sdk-s3', '~> 1'
Expand Down Expand Up @@ -88,7 +88,7 @@ gem 'google-apis-core'
gem 'google-apis-generator'
gem 'googleauth'
gem 'google-protobuf' # For Datadog Profiling
gem 'govdelivery-tms', git: 'https://github.com/department-of-veterans-affairs/govdelivery-tms-ruby.git', tag: 'v4.0.0', require: 'govdelivery/tms/mail/delivery_method'
gem 'govdelivery-tms', git: 'https://github.com/department-of-veterans-affairs/govdelivery-tms-ruby.git', tag: 'v4.1.0', require: 'govdelivery/tms/mail/delivery_method'
gem 'gyoku'
gem 'hexapdf'
gem 'holidays'
Expand Down
148 changes: 76 additions & 72 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
GIT
remote: https://github.com/StoneGod/activerecord-postgis-adapter.git
revision: 97bf3f6fdaa06383a4b2076172366efedc2f97f2
branch: rails-8
specs:
activerecord-postgis-adapter (10.0.0)
activerecord (~> 8.0.0)
rgeo-activerecord (~> 8.0.0)

GIT
remote: https://github.com/adhocteam/connect_vbms
revision: 2284b8e9a68d2b44dda52a098ffc83f8fa283211
Expand Down Expand Up @@ -64,11 +73,11 @@ GIT

GIT
remote: https://github.com/department-of-veterans-affairs/govdelivery-tms-ruby.git
revision: d58cc59ae47e5f5f642b3603224f42f518f92f56
tag: v4.0.0
revision: f50c995b4a92fa8da4488ed608318eeca723b543
tag: v4.1.0
specs:
govdelivery-tms (4.0.0)
activesupport (>= 5.2.4.3, < 8.0.0)
govdelivery-tms (4.1.0)
activesupport (>= 5.2.4.3, < 9.0.0)
faraday
mime-types

Expand Down Expand Up @@ -156,71 +165,67 @@ GEM
Ascii85 (1.1.0)
aasm (5.5.0)
concurrent-ruby (~> 1.0)
actioncable (7.2.2.1)
actionpack (= 7.2.2.1)
activesupport (= 7.2.2.1)
actioncable (8.0.0.1)
actionpack (= 8.0.0.1)
activesupport (= 8.0.0.1)
nio4r (~> 2.0)
websocket-driver (>= 0.6.1)
zeitwerk (~> 2.6)
actionmailbox (7.2.2.1)
actionpack (= 7.2.2.1)
activejob (= 7.2.2.1)
activerecord (= 7.2.2.1)
activestorage (= 7.2.2.1)
activesupport (= 7.2.2.1)
actionmailbox (8.0.0.1)
actionpack (= 8.0.0.1)
activejob (= 8.0.0.1)
activerecord (= 8.0.0.1)
activestorage (= 8.0.0.1)
activesupport (= 8.0.0.1)
mail (>= 2.8.0)
actionmailer (7.2.2.1)
actionpack (= 7.2.2.1)
actionview (= 7.2.2.1)
activejob (= 7.2.2.1)
activesupport (= 7.2.2.1)
actionmailer (8.0.0.1)
actionpack (= 8.0.0.1)
actionview (= 8.0.0.1)
activejob (= 8.0.0.1)
activesupport (= 8.0.0.1)
mail (>= 2.8.0)
rails-dom-testing (~> 2.2)
actionpack (7.2.2.1)
actionview (= 7.2.2.1)
activesupport (= 7.2.2.1)
actionpack (8.0.0.1)
actionview (= 8.0.0.1)
activesupport (= 8.0.0.1)
nokogiri (>= 1.8.5)
racc
rack (>= 2.2.4, < 3.2)
rack (>= 2.2.4)
rack-session (>= 1.0.1)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.2)
rails-html-sanitizer (~> 1.6)
useragent (~> 0.16)
actiontext (7.2.2.1)
actionpack (= 7.2.2.1)
activerecord (= 7.2.2.1)
activestorage (= 7.2.2.1)
activesupport (= 7.2.2.1)
actiontext (8.0.0.1)
actionpack (= 8.0.0.1)
activerecord (= 8.0.0.1)
activestorage (= 8.0.0.1)
activesupport (= 8.0.0.1)
globalid (>= 0.6.0)
nokogiri (>= 1.8.5)
actionview (7.2.2.1)
activesupport (= 7.2.2.1)
actionview (8.0.0.1)
activesupport (= 8.0.0.1)
builder (~> 3.1)
erubi (~> 1.11)
rails-dom-testing (~> 2.2)
rails-html-sanitizer (~> 1.6)
activejob (7.2.2.1)
activesupport (= 7.2.2.1)
activejob (8.0.0.1)
activesupport (= 8.0.0.1)
globalid (>= 0.3.6)
activemodel (7.2.2.1)
activesupport (= 7.2.2.1)
activerecord (7.2.2.1)
activemodel (= 7.2.2.1)
activesupport (= 7.2.2.1)
activemodel (8.0.0.1)
activesupport (= 8.0.0.1)
activerecord (8.0.0.1)
activemodel (= 8.0.0.1)
activesupport (= 8.0.0.1)
timeout (>= 0.4.0)
activerecord-import (1.8.1)
activerecord (>= 4.2)
activerecord-postgis-adapter (10.0.1)
activerecord (~> 7.2.0)
rgeo-activerecord (~> 8.0.0)
activestorage (7.2.2.1)
actionpack (= 7.2.2.1)
activejob (= 7.2.2.1)
activerecord (= 7.2.2.1)
activesupport (= 7.2.2.1)
activestorage (8.0.0.1)
actionpack (= 8.0.0.1)
activejob (= 8.0.0.1)
activerecord (= 8.0.0.1)
activesupport (= 8.0.0.1)
marcel (~> 1.0)
activesupport (7.2.2.1)
activesupport (8.0.0.1)
base64
benchmark (>= 0.3)
bigdecimal
Expand All @@ -232,6 +237,7 @@ GEM
minitest (>= 5.1)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
uri (>= 0.13.1)
addressable (2.8.7)
public_suffix (>= 2.0.2, < 7.0)
adler32 (0.0.2)
Expand Down Expand Up @@ -480,9 +486,9 @@ GEM
flipper-active_record (1.3.2)
activerecord (>= 4.2, < 9)
flipper (~> 1.3.2)
flipper-active_support_cache_store (1.3.1)
activesupport (>= 4.2, < 8)
flipper (~> 1.3.1)
flipper-active_support_cache_store (1.3.2)
activesupport (>= 4.2, < 9)
flipper (~> 1.3.2)
flipper-ui (1.3.1)
erubi (>= 1.0.0, < 2.0.0)
flipper (~> 1.3.1)
Expand Down Expand Up @@ -598,7 +604,7 @@ GEM
rdoc (>= 4.0.0)
reline (>= 0.4.2)
iso_country_codes (0.7.8)
jar-dependencies (0.5.0)
jar-dependencies (0.5.1)
jmespath (1.6.2)
jruby-openssl (0.15.1-java)
json (2.9.0)
Expand Down Expand Up @@ -694,11 +700,9 @@ GEM
nio4r (2.7.4-java)
nkf (0.2.0)
nkf (0.2.0-java)
nokogiri (1.16.8)
nokogiri (1.17.1)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.16.8-java)
racc (~> 1.4)
nori (2.7.1)
bigdecimal
notiffany (0.1.3)
Expand Down Expand Up @@ -816,20 +820,20 @@ GEM
rackup (1.0.1)
rack (< 3)
webrick
rails (7.2.2.1)
actioncable (= 7.2.2.1)
actionmailbox (= 7.2.2.1)
actionmailer (= 7.2.2.1)
actionpack (= 7.2.2.1)
actiontext (= 7.2.2.1)
actionview (= 7.2.2.1)
activejob (= 7.2.2.1)
activemodel (= 7.2.2.1)
activerecord (= 7.2.2.1)
activestorage (= 7.2.2.1)
activesupport (= 7.2.2.1)
rails (8.0.0.1)
actioncable (= 8.0.0.1)
actionmailbox (= 8.0.0.1)
actionmailer (= 8.0.0.1)
actionpack (= 8.0.0.1)
actiontext (= 8.0.0.1)
actionview (= 8.0.0.1)
activejob (= 8.0.0.1)
activemodel (= 8.0.0.1)
activerecord (= 8.0.0.1)
activestorage (= 8.0.0.1)
activesupport (= 8.0.0.1)
bundler (>= 1.15.0)
railties (= 7.2.2.1)
railties (= 8.0.0.1)
rails-dom-testing (2.2.0)
activesupport (>= 5.0.0)
minitest
Expand All @@ -843,9 +847,9 @@ GEM
rack
railties (>= 5.1)
semantic_logger (~> 4.16)
railties (7.2.2.1)
actionpack (= 7.2.2.1)
activesupport (= 7.2.2.1)
railties (8.0.0.1)
actionpack (= 8.0.0.1)
activesupport (= 8.0.0.1)
irb (~> 1.13)
rackup (>= 1.0.0)
rake (>= 12.2)
Expand Down Expand Up @@ -1068,7 +1072,7 @@ GEM
tzinfo (>= 1.0.0)
uber (0.1.0)
unicode-display_width (2.6.0)
uri (0.13.1)
uri (1.0.2)
useragent (0.16.11)
utf8-cleaner (1.0.0)
activesupport
Expand Down Expand Up @@ -1133,7 +1137,7 @@ DEPENDENCIES
aasm
accredited_representative_portal!
activerecord-import
activerecord-postgis-adapter
activerecord-postgis-adapter!
addressable
apivore!
appeals_api!
Expand Down Expand Up @@ -1265,7 +1269,7 @@ DEPENDENCIES
rack-test (= 2.1.0)
rack-timeout
rack-vcr
rails (~> 7.2.2)
rails (~> 8.0.0)
rails-session_cookie
rails_semantic_logger
rainbow
Expand Down
2 changes: 1 addition & 1 deletion modules/vba_documents/spec/models/upload_file_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@
it 'does not instantiatiate on UploadSubmission' do
upload_model = VBADocuments::UploadSubmission.new
upload_model.save!
expect { VBADocuments::UploadFile.find_by(guid: upload_model.guid) }.to raise_error(ActiveRecord::StatementInvalid)
expect { VBADocuments::UploadFile.find_by(guid: upload_model.guid) }.to raise_error(TypeError)
Copy link
Contributor Author

@ryan-mcneil ryan-mcneil Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find the exact change, but in previous versions it seems that errors raised during activerecord execution were raised as ActiveRecord::StatementInvalid. Now it seems that it raises the error explicitly raised in the code

end
end
Loading