Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rails 7.2.2 -> 8.0.0 #19853

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,9 @@ config/initializers/kms_encrypted.rb @department-of-veterans-affairs/va-api-engi
config/initializers/loa.rb @department-of-veterans-affairs/octo-identity
config/initializers/lockbox.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
config/initializers/mime_types.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
config/initializers/new_framework_defaults_7_0.rb @department-of-veterans-affairs/backend-review-group
config/initializers/new_framework_defaults_7_1.rb @department-of-veterans-affairs/backend-review-group
config/initializers/new_framework_defaults_8_0.rb @department-of-veterans-affairs/backend-review-group
config/initializers/okcomputer.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
config/initializers/override_redirect_to_logging.rb @department-of-veterans-affairs/octo-identity
config/initializers/rack_attack.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
Expand Down
6 changes: 3 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ path 'modules' do
gem 'vye'
end

gem 'rails', '~> 7.2.2'
gem 'rails', '~> 8.0.0'

gem 'aasm'
gem 'activerecord-import'
gem 'activerecord-postgis-adapter'
gem 'activerecord-postgis-adapter', github: 'StoneGod/activerecord-postgis-adapter', branch: 'rails-8'
gem 'addressable'
gem 'aws-sdk-kms'
gem 'aws-sdk-s3', '~> 1'
Expand Down Expand Up @@ -89,7 +89,7 @@ gem 'google-apis-core'
gem 'google-apis-generator'
gem 'googleauth'
gem 'google-protobuf' # For Datadog Profiling
gem 'govdelivery-tms', git: 'https://github.com/department-of-veterans-affairs/govdelivery-tms-ruby.git', tag: 'v4.0.0', require: 'govdelivery/tms/mail/delivery_method'
gem 'govdelivery-tms', git: 'https://github.com/department-of-veterans-affairs/govdelivery-tms-ruby.git', tag: 'v4.1.0', require: 'govdelivery/tms/mail/delivery_method'
gem 'gyoku'
gem 'hexapdf'
gem 'holidays'
Expand Down
157 changes: 81 additions & 76 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
GIT
remote: https://github.com/StoneGod/activerecord-postgis-adapter.git
revision: 97bf3f6fdaa06383a4b2076172366efedc2f97f2
branch: rails-8
specs:
activerecord-postgis-adapter (10.0.0)
activerecord (~> 8.0.0)
rgeo-activerecord (~> 8.0.0)

GIT
remote: https://github.com/adhocteam/connect_vbms
revision: 2284b8e9a68d2b44dda52a098ffc83f8fa283211
Expand Down Expand Up @@ -64,11 +73,11 @@ GIT

GIT
remote: https://github.com/department-of-veterans-affairs/govdelivery-tms-ruby.git
revision: d58cc59ae47e5f5f642b3603224f42f518f92f56
tag: v4.0.0
revision: f50c995b4a92fa8da4488ed608318eeca723b543
tag: v4.1.0
specs:
govdelivery-tms (4.0.0)
activesupport (>= 5.2.4.3, < 8.0.0)
govdelivery-tms (4.1.0)
activesupport (>= 5.2.4.3, < 9.0.0)
faraday
mime-types

Expand Down Expand Up @@ -157,71 +166,67 @@ GEM
Ascii85 (1.1.0)
aasm (5.5.0)
concurrent-ruby (~> 1.0)
actioncable (7.2.2.1)
actionpack (= 7.2.2.1)
activesupport (= 7.2.2.1)
actioncable (8.0.1)
actionpack (= 8.0.1)
activesupport (= 8.0.1)
nio4r (~> 2.0)
websocket-driver (>= 0.6.1)
zeitwerk (~> 2.6)
actionmailbox (7.2.2.1)
actionpack (= 7.2.2.1)
activejob (= 7.2.2.1)
activerecord (= 7.2.2.1)
activestorage (= 7.2.2.1)
activesupport (= 7.2.2.1)
actionmailbox (8.0.1)
actionpack (= 8.0.1)
activejob (= 8.0.1)
activerecord (= 8.0.1)
activestorage (= 8.0.1)
activesupport (= 8.0.1)
mail (>= 2.8.0)
actionmailer (7.2.2.1)
actionpack (= 7.2.2.1)
actionview (= 7.2.2.1)
activejob (= 7.2.2.1)
activesupport (= 7.2.2.1)
actionmailer (8.0.1)
actionpack (= 8.0.1)
actionview (= 8.0.1)
activejob (= 8.0.1)
activesupport (= 8.0.1)
mail (>= 2.8.0)
rails-dom-testing (~> 2.2)
actionpack (7.2.2.1)
actionview (= 7.2.2.1)
activesupport (= 7.2.2.1)
actionpack (8.0.1)
actionview (= 8.0.1)
activesupport (= 8.0.1)
nokogiri (>= 1.8.5)
racc
rack (>= 2.2.4, < 3.2)
rack (>= 2.2.4)
rack-session (>= 1.0.1)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.2)
rails-html-sanitizer (~> 1.6)
useragent (~> 0.16)
actiontext (7.2.2.1)
actionpack (= 7.2.2.1)
activerecord (= 7.2.2.1)
activestorage (= 7.2.2.1)
activesupport (= 7.2.2.1)
actiontext (8.0.1)
actionpack (= 8.0.1)
activerecord (= 8.0.1)
activestorage (= 8.0.1)
activesupport (= 8.0.1)
globalid (>= 0.6.0)
nokogiri (>= 1.8.5)
actionview (7.2.2.1)
activesupport (= 7.2.2.1)
actionview (8.0.1)
activesupport (= 8.0.1)
builder (~> 3.1)
erubi (~> 1.11)
rails-dom-testing (~> 2.2)
rails-html-sanitizer (~> 1.6)
activejob (7.2.2.1)
activesupport (= 7.2.2.1)
activejob (8.0.1)
activesupport (= 8.0.1)
globalid (>= 0.3.6)
activemodel (7.2.2.1)
activesupport (= 7.2.2.1)
activerecord (7.2.2.1)
activemodel (= 7.2.2.1)
activesupport (= 7.2.2.1)
activemodel (8.0.1)
activesupport (= 8.0.1)
activerecord (8.0.1)
activemodel (= 8.0.1)
activesupport (= 8.0.1)
timeout (>= 0.4.0)
activerecord-import (1.8.1)
activerecord (>= 4.2)
activerecord-postgis-adapter (10.0.1)
activerecord (~> 7.2.0)
rgeo-activerecord (~> 8.0.0)
activestorage (7.2.2.1)
actionpack (= 7.2.2.1)
activejob (= 7.2.2.1)
activerecord (= 7.2.2.1)
activesupport (= 7.2.2.1)
activestorage (8.0.1)
actionpack (= 8.0.1)
activejob (= 8.0.1)
activerecord (= 8.0.1)
activesupport (= 8.0.1)
marcel (~> 1.0)
activesupport (7.2.2.1)
activesupport (8.0.1)
base64
benchmark (>= 0.3)
bigdecimal
Expand All @@ -233,6 +238,7 @@ GEM
minitest (>= 5.1)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
uri (>= 0.13.1)
addressable (2.8.7)
public_suffix (>= 2.0.2, < 7.0)
adler32 (0.0.2)
Expand Down Expand Up @@ -428,7 +434,7 @@ GEM
dry-schema (>= 1.12, < 2)
zeitwerk (~> 2.6)
einhorn (1.0.0)
erubi (1.13.0)
erubi (1.13.1)
et-orbi (1.2.11)
tzinfo
ethon (0.16.0)
Expand Down Expand Up @@ -488,9 +494,9 @@ GEM
flipper-active_record (1.3.2)
activerecord (>= 4.2, < 9)
flipper (~> 1.3.2)
flipper-active_support_cache_store (1.3.1)
activesupport (>= 4.2, < 8)
flipper (~> 1.3.1)
flipper-active_support_cache_store (1.3.2)
activesupport (>= 4.2, < 9)
flipper (~> 1.3.2)
flipper-ui (1.3.1)
erubi (>= 1.0.0, < 2.0.0)
flipper (~> 1.3.1)
Expand Down Expand Up @@ -608,7 +614,6 @@ GEM
rdoc (>= 4.0.0)
reline (>= 0.4.2)
iso_country_codes (0.7.8)
jar-dependencies (0.5.1)
jmespath (1.6.2)
jruby-openssl (0.15.1-java)
json (2.9.1)
Expand Down Expand Up @@ -654,7 +659,7 @@ GEM
rake (~> 13.0)
lockbox (2.0.1)
logger (1.6.4)
loofah (2.23.1)
loofah (2.24.0)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
lumberjack (1.2.10)
Expand Down Expand Up @@ -689,7 +694,7 @@ GEM
nenv (0.3.0)
net-http (0.6.0)
uri
net-imap (0.5.1)
net-imap (0.5.5)
date
net-protocol
net-pop (0.1.2)
Expand Down Expand Up @@ -800,9 +805,6 @@ GEM
psych (5.2.2)
date
stringio
psych (5.2.2-java)
date
jar-dependencies (>= 0.1.7)
public_suffix (6.0.1)
puma (6.5.0)
nio4r (~> 2.0)
Expand Down Expand Up @@ -831,20 +833,20 @@ GEM
rackup (1.0.1)
rack (< 3)
webrick
rails (7.2.2.1)
actioncable (= 7.2.2.1)
actionmailbox (= 7.2.2.1)
actionmailer (= 7.2.2.1)
actionpack (= 7.2.2.1)
actiontext (= 7.2.2.1)
actionview (= 7.2.2.1)
activejob (= 7.2.2.1)
activemodel (= 7.2.2.1)
activerecord (= 7.2.2.1)
activestorage (= 7.2.2.1)
activesupport (= 7.2.2.1)
rails (8.0.1)
actioncable (= 8.0.1)
actionmailbox (= 8.0.1)
actionmailer (= 8.0.1)
actionpack (= 8.0.1)
actiontext (= 8.0.1)
actionview (= 8.0.1)
activejob (= 8.0.1)
activemodel (= 8.0.1)
activerecord (= 8.0.1)
activestorage (= 8.0.1)
activesupport (= 8.0.1)
bundler (>= 1.15.0)
railties (= 7.2.2.1)
railties (= 8.0.1)
rails-dom-testing (2.2.0)
activesupport (>= 5.0.0)
minitest
Expand All @@ -858,9 +860,9 @@ GEM
rack
railties (>= 5.1)
semantic_logger (~> 4.16)
railties (7.2.2.1)
actionpack (= 7.2.2.1)
activesupport (= 7.2.2.1)
railties (8.0.1)
actionpack (= 8.0.1)
activesupport (= 8.0.1)
irb (~> 1.13)
rackup (>= 1.0.0)
rake (>= 12.2)
Expand Down Expand Up @@ -1058,6 +1060,7 @@ GEM
staccato (0.5.3)
statsd-instrument (3.9.8)
stringio (3.1.2)
stringio (3.1.2-java)
strong_migrations (2.1.0)
activerecord (>= 6.1)
super_diff (0.14.0)
Expand Down Expand Up @@ -1115,9 +1118,11 @@ GEM
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
webrick (1.9.1)
websocket-driver (0.7.6)
websocket-driver (0.7.7)
base64
websocket-extensions (>= 0.1.0)
websocket-driver (0.7.6-java)
websocket-driver (0.7.7-java)
base64
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
will_paginate (4.0.1)
Expand Down Expand Up @@ -1149,7 +1154,7 @@ DEPENDENCIES
aasm
accredited_representative_portal!
activerecord-import
activerecord-postgis-adapter
activerecord-postgis-adapter!
addressable
apivore!
appeals_api!
Expand Down Expand Up @@ -1283,7 +1288,7 @@ DEPENDENCIES
rack-test (= 2.2.0)
rack-timeout
rack-vcr
rails (~> 7.2.2)
rails (~> 8.0.0)
rails-session_cookie
rails_semantic_logger
rainbow
Expand Down
9 changes: 9 additions & 0 deletions bin/brakeman
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/usr/bin/env ruby
# frozen_string_literal: true

require 'rubygems'
require 'bundler/setup'

ARGV.unshift('--ensure-latest')

load Gem.bin_path('brakeman', 'brakeman')
10 changes: 10 additions & 0 deletions bin/rubocop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#!/usr/bin/env ruby
# frozen_string_literal: true

require 'rubygems'
require 'bundler/setup'

# explicit rubocop config increases performance slightly while avoiding config confusion.
ARGV.unshift('--config', File.expand_path('../.rubocop.yml', __dir__))

load Gem.bin_path('rubocop', 'rubocop')
2 changes: 1 addition & 1 deletion bin/test
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ end
def ci_test_command
docker = 'docker compose run web bash -c'
runtime_variables = 'CI=true RAILS_ENV=test DISABLE_BOOTSNAP=true'
spec = "bundle exec parallel_rspec spec/ modules/ -n 8 -o '--color --tty'"
spec = "bundle exec parallel_rspec spec/ modules/ -n 8 -o '--color --tty --format documentation'"
"#{docker} \"#{runtime_variables} #{spec}\""
end

Expand Down
5 changes: 5 additions & 0 deletions config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ class Application < Rails::Application
# https://guides.rubyonrails.org/configuring.html#default-values-for-target-version-7-0
config.load_defaults 7.1

# Please, add to the `ignore` list any other `lib` subdirectories that do
# not contain `.rb` files, or that should not be reloaded or eager loaded.
# Common ones are `templates`, `generators`, or `middleware`, for example.
# config.autoload_lib(ignore: %w[assets])

# Configuration for the application, engines, and railties goes here.
#
# These settings can be overridden in specific environments using the files
Expand Down
Loading
Loading