Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbex/97956-separation-location-string: temporary - turn separation loccation code into string for saved claim #19632

Merged
merged 9 commits into from
Nov 27, 2024
Merged

dbex/97956-separation-location-string: temporary - turn separation loccation code into string for saved claim #19632

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d9ac0a8
dbex/97956-separation-location-string: temporary - turn separation lo…
aurora-a-k-a-lightning Nov 26, 2024
b745bf7
dbex/97956-separation-location-string: temporary - turn separation lo…
aurora-a-k-a-lightning Nov 26, 2024
3626920
dbex/97956-separation-location-string: temporary - turn separation lo…
aurora-a-k-a-lightning Nov 26, 2024
19b32d3
dbex/97956-separation-location-string: temporary - turn separation lo…
aurora-a-k-a-lightning Nov 26, 2024
d26dd5e
dbex/97956-separation-location-string: enter flipper flag: disability…
aurora-a-k-a-lightning Nov 27, 2024
1de412a
dbex/97956-separation-location-string: enter flipper flag: disability…
aurora-a-k-a-lightning Nov 27, 2024
117f302
dbex/97956-separation-location-string: enter flipper flag: disability…
aurora-a-k-a-lightning Nov 27, 2024
3c51878
dbex/97956-separation-location-string: enter flipper flag: disability…
aurora-a-k-a-lightning Nov 27, 2024
008fe60
dbex/97956-separation-location-string: enter flipper flag: disability…
aurora-a-k-a-lightning Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/controllers/v0/disability_compensation_forms_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def suggested_conditions
end

def submit_all_claim
temp_separation_location_fix

saved_claim = SavedClaim::DisabilityCompensation::Form526AllClaim.from_hash(form_content)
saved_claim.save ? log_success(saved_claim) : log_failure(saved_claim)
submission = create_submission(saved_claim)
Expand Down Expand Up @@ -172,5 +174,17 @@ def missing_disabilities?(submission)
end
false
end

# TEMPORARY
# Turn separation location into string
# 11/18/2024 BRD EVSS -> Lighthouse migration caused separation location to turn into an integer,
# while SavedClaim (vets-json-schema) is expecting a string
def temp_separation_location_fix
separation_location_code =
form_content['form526']['serviceInformation']['separationLocation']['separationLocationCode'].to_s
form_content['form526']['serviceInformation']['separationLocation']['separationLocationCode'] =
separation_location_code
end
# END TEMPORARY
end
end
Loading