dbex/97956-separation-location-string: temporary - turn separation loccation code into string for saved claim

[aurora-a-k-a-lightning]

Summary

• This work is behind a feature toggle (flipper): YES
• in #submit_all_claim, force separation location code to be a string

Related issue(s)

• Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira

Testing done

• turn on BRD separation location migration http://localhost:3000/flipper/features/disability_compensation_lighthouse_brd
• start BDD claim
• choose separation location
• submit application
• before: submit_all_claim would return an error
• turn on http://localhost:3000/flipper/features/disability_compensation_temp_separation_location_code_string
• after: submit_all_claim should create a sidekiq job!

Screenshots

n/a

What areas of the site does it impact?

#5264lyfe

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[kylesoskin]

 def temp_separation_location_fix
  if form_content.is_a?(Hash)
    separation_location_code = form_content.dig('form526', 'serviceInformation', 'separationLocation')
    form_content['form526']['serviceInformation']['separationLocation'] = separation_location_code.to_s unless separation_location_code.nil?
  end
end

Does this accomplish the same thing? Approved regardless, but just saying

If you tested yours, and if works, do that for sure to get fix in asap.

[github-actions]

Backend-review-group approval confirmed.