Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes syntax on optional param for sidekiq job #18349

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fixes syntax on optional param for sidekiq job #18349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/claims_api/app/controllers/claims_api/v1/forms/power_of_attorney_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def upload
@power_of_attorney.reload

# If upload is successful, then the PoaUpater job is also called to update the code in BGS.
ClaimsApi::PoaVBMSUploadJob.perform_async(@power_of_attorney.id, action: 'put')
ClaimsApi::PoaVBMSUploadJob.perform_async(@power_of_attorney.id, 'put')

render json: ClaimsApi::PowerOfAttorneySerializer.new(@power_of_attorney)
end
Expand Down
2 changes: 1 addition & 1 deletion modules/claims_api/app/sidekiq/claims_api/poa_vbms_upload_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class PoaVBMSUploadJob < ClaimsApi::ServiceBase
# If successfully uploaded, it queues a job to update the POA code in BGS, as well.
#
# @param power_of_attorney_id [String] Unique identifier of the submitted POA
def perform(power_of_attorney_id, action: 'post')
def perform(power_of_attorney_id, action = 'post')
power_of_attorney = ClaimsApi::PowerOfAttorney.find(power_of_attorney_id)
uploader = ClaimsApi::PowerOfAttorneyUploader.new(power_of_attorney_id)
uploader.retrieve_from_store!(power_of_attorney.file_data['filename'])
Expand Down
Loading