Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes syntax on optional param for sidekiq job #18349

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

rockwellwindsor-va
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va commented Sep 6, 2024

Summary

  • Fixes syntax on optional param sent to job

Related issue(s)

API-39286

Testing done

  • Submissions uploaded still reflect the desired file name. All async workflows ran as expected.

Screenshots

Screenshot 2024-09-06 at 12 40 59 PM

What areas of the site does it impact?

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@rockwellwindsor-va rockwellwindsor-va added the claimsApi modules/claims_api label Sep 6, 2024
@rockwellwindsor-va rockwellwindsor-va marked this pull request as ready for review September 6, 2024 17:25
@rockwellwindsor-va rockwellwindsor-va requested a review from a team as a code owner September 6, 2024 17:25
@rjohnson2011 rjohnson2011 merged commit 50c2778 into master Sep 6, 2024
27 of 30 checks passed
@rjohnson2011 rjohnson2011 deleted the API-39286-hotfix-for-param-issue branch September 6, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants