-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBX-82245] implement LH getPDF for 526 backup path #16876
Merged
tblackwe
merged 39 commits into
master
from
dbx-82245/implement-backup-submission-lh-api-factory
Jun 17, 2024
Merged
[DBX-82245] implement LH getPDF for 526 backup path #16876
tblackwe
merged 39 commits into
master
from
dbx-82245/implement-backup-submission-lh-api-factory
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
May 24, 2024 17:55
Inactive
SamStuckey
force-pushed
the
dbx-82245/implement-backup-submission-lh-api-factory
branch
from
May 24, 2024 17:55
1d8eaec
to
92e93eb
Compare
SamStuckey
commented
May 24, 2024
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
May 24, 2024 18:05
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
May 24, 2024 19:22
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
May 28, 2024 15:33
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
May 28, 2024 19:27
Inactive
5 tasks
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
May 31, 2024 20:22
Inactive
SamStuckey
force-pushed
the
dbx-82245/implement-backup-submission-lh-api-factory
branch
from
June 4, 2024 19:02
612d86b
to
dd93482
Compare
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 4, 2024 19:37
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 6, 2024 21:22
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 6, 2024 22:08
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 6, 2024 22:30
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 10, 2024 20:49
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 12, 2024 19:38
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 12, 2024 20:16
Inactive
…f github.com:department-of-veterans-affairs/vets-api into dbx-82245/implement-backup-submission-lh-api-factory
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 12, 2024 21:26
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 12, 2024 22:21
Inactive
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 12, 2024 22:27
Inactive
freeheeling
reviewed
Jun 12, 2024
freeheeling
reviewed
Jun 12, 2024
freeheeling
reviewed
Jun 12, 2024
spec/lib/sidekiq/form526_backup_submission_process/processor_spec.rb
Outdated
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 13, 2024 16:06
Inactive
freeheeling
reviewed
Jun 13, 2024
spec/lib/sidekiq/form526_backup_submission_process/processor_spec.rb
Outdated
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
dbx-82245/implement-backup-submission-lh-api-factory/main/main
June 13, 2024 17:27
Inactive
freeheeling
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
tblackwe
deleted the
dbx-82245/implement-backup-submission-lh-api-factory
branch
June 17, 2024 13:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to submit backup submissions using PDFs generated by the correct Service based on initial submission path.
Related issue(s)
Testing done
then fetch the claim from Benefits Intake API
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?