Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBX-82245] implement LH getPDF for 526 backup path #16876

Merged
merged 39 commits into from
Jun 17, 2024

Conversation

SamStuckey
Copy link
Contributor

@SamStuckey SamStuckey commented May 24, 2024

Summary

Adds the ability to submit backup submissions using PDFs generated by the correct Service based on initial submission path.

  • *This work is behind a feature toggle (flipper): * Indirectly Yes
  • Adding conditional path based on if claim was submitted to claims_api (instead of EVSS). In new path, PDFs will be generated using appropriate API
  • Disability

Related issue(s)

Testing done

  • New code is covered by unit tests
  • PDFs always generated using EVSS, now they are generated by which endpoint the primary submission would have used
  • Generate Lighthouse claim, trigger backup submission using code:
sub = <your Form526Submission>
processor = Sidekiq::Form526BackupSubmissionProcess::Processor.new(sub.id, get_upload_location_on_instantiation: false)
processor.process!

then fetch the claim from Benefits Intake API

  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • This path is part of the backup submission process. It will be monitored closely and coordinated with OBI to ensure proper resolution of submission

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main May 24, 2024 17:55 Inactive
@SamStuckey SamStuckey force-pushed the dbx-82245/implement-backup-submission-lh-api-factory branch from 1d8eaec to 92e93eb Compare May 24, 2024 17:55
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main May 24, 2024 18:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main May 24, 2024 19:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main May 28, 2024 15:33 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main May 28, 2024 19:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main May 31, 2024 20:22 Inactive
@SamStuckey SamStuckey force-pushed the dbx-82245/implement-backup-submission-lh-api-factory branch from 612d86b to dd93482 Compare June 4, 2024 19:02
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 4, 2024 19:37 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 6, 2024 21:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 6, 2024 22:08 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 6, 2024 22:30 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 10, 2024 20:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 12, 2024 19:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 12, 2024 20:16 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 12, 2024 21:26 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 12, 2024 22:21 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 12, 2024 22:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 13, 2024 16:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbx-82245/implement-backup-submission-lh-api-factory/main/main June 13, 2024 17:27 Inactive
Copy link
Contributor

@freeheeling freeheeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tblackwe tblackwe marked this pull request as ready for review June 17, 2024 13:21
@tblackwe tblackwe requested review from a team as code owners June 17, 2024 13:21
@tblackwe tblackwe merged commit 3d02ea8 into master Jun 17, 2024
19 checks passed
@tblackwe tblackwe deleted the dbx-82245/implement-backup-submission-lh-api-factory branch June 17, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants