Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update checkboxes to be x's #16334

Merged
merged 1 commit into from
Apr 16, 2024
Merged

update checkboxes to be x's #16334

merged 1 commit into from
Apr 16, 2024

Conversation

evansmith
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

-YES va_burial_v2

  • Changed the formatting of the PDF to check boxes as X instead of a square.
  • Altered the properties within adobe acrobat
  • VA Benefits and Claims

Related issue(s)

- Link to ticket created in va.gov-team repo OR screenshot of Jira ticket if your team uses Jira

Testing done

  • New code is covered by unit tests
  • Prior, checkboxes were filled in by squares or dots.
    -Fill out a claim and verify the generated PDF has X's in the boxes. Alternatively, pull a blank copy of the pdf from the repo and confirm manually.

Screenshots

Note: Optional

What areas of the site does it impact?

Burials V2

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@tblackwe tblackwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloaded the file and validated manually.

Copy link
Contributor

@rmtolmach rmtolmach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this your team's form? If so, you could add it to CODEOWNERS, because right now CODEOWNERS is falling back on this line:

lib/pdf_fill @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/vfs-1095-b

Tag me if you end up changing CODEOWNERS and I'll re-review.

@evansmith evansmith merged commit 986edc2 into master Apr 16, 2024
20 checks passed
@evansmith evansmith deleted the ndbex-80695-make-checkbox-x branch April 16, 2024 00:10
@tblackwe
Copy link
Contributor

I asked Evan to merge as is, we are auditing all our forms for ownership and will get them updated in a separate pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants