Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeowners - PDF Audit #80807

Closed
tblackwe opened this issue Apr 16, 2024 · 2 comments
Closed

Codeowners - PDF Audit #80807

tblackwe opened this issue Apr 16, 2024 · 2 comments

Comments

@tblackwe
Copy link
Contributor

Platform noted in PR #16334 that the codeowners for various pdfs + fillers was out of date

Please audit the vets-api codeowners file for ownership on pdfs and pdf fillers for:

Non-disability:
28-1900
28-8832
21-530 V1 & V2

Dependents
21-686C
21-674

@tblackwe tblackwe added the Umbrella Non-disability benefits team label Apr 16, 2024
@evansmith
Copy link

The generic folder of lib/pdf_fill defaults to this: lib/pdf_fill @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/vfs-1095-b

It seems like the files themselves are not covered by codeowners otherwise, but the test files are.

Narrowing down within lib:
28-1900 - no codeowners present
28-8823 - no codeowners present
21-530V1 - no codeowners present
21-530V2 - no codeowners present
21-686c - no codeowners present
21-674 - no codeowners present

Narrowing down within spec
28-1900 - spec/fixtures/pdf_fill/28-1900 @department-of-veterans-affairs/Benefits-Team-1 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
28-8832 - spec/fixtures/pdf_fill/28-8832 @department-of-veterans-affairs/Benefits-Team-1 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
21-530V1 - spec/fixtures/pdf_fill/21P-530 @department-of-veterans-affairs/Benefits-Team-1 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
21-530V2 - spec/fixtures/pdf_fill/21P-530V2 @department-of-veterans-affairs/Benefits-Team-1 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
21-686C - spec/fixtures/pdf_fill/686C-674 @department-of-veterans-affairs/Benefits-Team-1 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
21-674 - spec/fixtures/pdf_fill/21-674 @department-of-veterans-affairs/Benefits-Team-1 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group

@tblackwe
Copy link
Contributor Author

tblackwe commented Apr 16, 2024

Please update the owners as follows:

For each appropriate file in lib/pdf_fill/forms lib/pdf_fill/forms/pdfs and spec/fixtures/pdf_fill/

686/674 files owned by @department-of-veterans-affairs/benefits-dependents-management @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group

1900, 8832, 530 V1/V2 owned by @department-of-veterans-affairs/benefits-non-disability @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group

You can remove Benefits-Team-1 from the above spec files.

@evansmith evansmith self-assigned this Apr 16, 2024
@steele-lm steele-lm removed the Umbrella Non-disability benefits team label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants