Simple Forms: Refactor PDF Stamper Part 1

[Thrillberg]

Summary

This PR takes part of the work from this draft PR: #16242 and separates it into its own standalone PR. This should be more easily reviewable. I can then come back and apply part 2 in a separate PR and close out the aforementioned draft PR.

This is some refactoring of our PDF Stamper class with the ultimate aim of making it more uniform in how it handles desired stamps.

Related issue(s)

https://app.zenhub.com/workspaces/vagov-product-team-forms-634853151f5c6000165942bc/issues/gh/department-of-veterans-affairs/va.gov-team-forms/1198

Testing done

Tests altered and passing.

[github-actions]

1 Warning

⚠️

This PR changes 300 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/simple_forms_api/app/models/simple_forms_api/vba_20_10207.rb (+11/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0845.rb (+4/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0966.rb (+4/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0972.rb (+4/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_10210.rb (+4/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21_4142.rb (+4/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_21p_0847.rb (+4/-0) modules/simple_forms_api/app/models/simple_forms_api/vba_26_4555.rb (+12/-0) modules/simple_forms_api/app/models/simple_forms_api/vha_10_7959f_1.rb (+4/-0) modules/simple_forms_api/app/services/simple_forms_api/pdf_stamper.rb (+41/-141) modules/simple_forms_api/spec/services/pdf_stamper_spec.rb (+21/-46) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[stevenjcumming]

@Thrillberg Could you ask a teammate for a review, then I'll review it

[pennja]

Any reason this one was formatted differently?

[Thrillberg]

NAWP! Fixing now 😸

[pennja]

This could be rewritten with .tap:

Suggested change

	config = [
	{ type: :new_page },
	{ type: :new_page },
	{ type: :new_page },
	{ type: :new_page }
	]
	config[page] = { type: :text, position: }
	config
	[
	{ type: :new_page },
	{ type: :new_page },
	{ type: :new_page },
	{ type: :new_page }
	].tap do |config|
	config[page] = { type: :text, position: }
	end

[Thrillberg]

Ah yes! I need to get more used to tap.

[pennja]

Looks good to me, just one question and one small suggestion. 👍

[pennja]

Looks good to me, great work again! 👍