Simple Forms: PDF Stamper Refactor (Part II: The Refactorening)

[Thrillberg]

Summary

This concludes the two-part drama begun by this PR. These commits were cherry-picked from here.

Related issue(s)

https://app.zenhub.com/workspaces/vagov-product-team-forms-634853151f5c6000165942bc/issues/gh/department-of-veterans-affairs/va.gov-team-forms/1198

[github-actions]

1 Warning

⚠️

This PR changes 225 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/simple_forms_api/app/models/simple_forms_api/vba_20_10206.rb (+13/-5) modules/simple_forms_api/app/models/simple_forms_api/vba_20_10207.rb (+2/-4) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0845.rb (+13/-5) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0966.rb (+13/-5) modules/simple_forms_api/app/models/simple_forms_api/vba_21_0972.rb (+13/-5) modules/simple_forms_api/app/models/simple_forms_api/vba_21_10210.rb (+13/-5) modules/simple_forms_api/app/models/simple_forms_api/vba_21_4142.rb (+36/-7) modules/simple_forms_api/app/models/simple_forms_api/vba_21p_0847.rb (+13/-5) modules/simple_forms_api/app/models/simple_forms_api/vba_26_4555.rb (+2/-2) modules/simple_forms_api/app/models/simple_forms_api/vba_40_0247.rb (+2/-2) modules/simple_forms_api/app/models/simple_forms_api/vba_40_10007.rb (+2/-2) modules/simple_forms_api/app/models/simple_forms_api/vha_10_10d.rb (+2/-2) modules/simple_forms_api/app/models/simple_forms_api/vha_10_7959c.rb (+2/-7) modules/simple_forms_api/app/models/simple_forms_api/vha_10_7959f_1.rb (+2/-2) modules/simple_forms_api/app/models/simple_forms_api/vha_10_7959f_2.rb (+2/-2) modules/simple_forms_api/app/services/simple_forms_api/pdf_stamper.rb (+7/-25) modules/simple_forms_api/spec/services/pdf_stamper_spec.rb (+2/-1) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[pennja]

Looks good, great work! 👍