-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
72706 Create ivc_champva Module #16091
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lines up with previous implementation progress. It will be good to have a separate IVC module so we're not stepping on toes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay. I ran it locally
modules/ivc_champva/app/controllers/ivc_champva/v1/uploads_controller.rb
Outdated
Show resolved
Hide resolved
modules/ivc_champva/app/controllers/ivc_champva/v1/uploads_controller.rb
Outdated
Show resolved
Hide resolved
This reverts commit 99fea10.
Summary
When the IVC team first came together we leveraged SimpleFormsAPI module to hit the ground running. Now that we have a better understanding of the code and begin to branch off of SFA more and more it made sense to create our own module.
vtk
to generate the scaffolding for the newivc_champva
moduleRelated issue(s)
Testing done
/ivc_champva/v1/forms
in the browser and saw the files uploaded in S3/ivc_champva/v1/forms/submit_supporting_documents
in the browser as wellWhat areas of the site does it impact?