Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

72706 Create ivc_champva Module #16091

Merged
merged 20 commits into from
Mar 29, 2024
Merged

Conversation

balexandr
Copy link
Contributor

Summary

When the IVC team first came together we leveraged SimpleFormsAPI module to hit the ground running. Now that we have a better understanding of the code and begin to branch off of SFA more and more it made sense to create our own module.

  • Utilized vtk to generate the scaffolding for the new ivc_champva module
  • Ported the code over from SimpleFormsAPI and unravelled the logic
  • Cleaned up a lot of the code and made it a bit more readable

Related issue(s)

Testing done

  • Tested the new route /ivc_champva/v1/forms in the browser and saw the files uploaded in S3
  • Tested the new route /ivc_champva/v1/forms/submit_supporting_documents in the browser as well
  • Updated and ran Rspec tests

What areas of the site does it impact?

  • This is a brand new module so it shouldn't effect any other aspects of vets-api

@va-vfs-bot va-vfs-bot temporarily deployed to 72706-create-ivcchampva-module/main/main March 26, 2024 18:37 Inactive
Copy link

github-actions bot commented Mar 26, 2024

1 Error
🚫 This PR changes 1977 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • Gemfile (+1/-0)

  • config/routes.rb (+1/-0)

  • modules/ivc_champva/Gemfile (+16/-0)

  • modules/ivc_champva/README.rdoc (+19/-0)

  • modules/ivc_champva/Rakefile (+31/-0)

  • modules/ivc_champva/app/controllers/ivc_champva/v1/application_controller.rb (+9/-0)

  • modules/ivc_champva/app/controllers/ivc_champva/v1/uploads_controller.rb (+100/-0)

  • modules/ivc_champva/app/form_mappings/vha_10_10d.json.erb (+74/-0)

  • modules/ivc_champva/app/form_mappings/vha_10_7959c.json.erb (+63/-0)

  • modules/ivc_champva/app/form_mappings/vha_10_7959f_1.json.erb (+16/-0)

  • modules/ivc_champva/app/form_mappings/vha_10_7959f_2.json.erb (+17/-0)

  • modules/ivc_champva/app/models/ivc_champva/vha_10_10d.rb (+46/-0)

  • modules/ivc_champva/app/models/ivc_champva/vha_10_7959c.rb (+43/-0)

  • modules/ivc_champva/app/models/ivc_champva/vha_10_7959f_1.rb (+38/-0)

  • modules/ivc_champva/app/models/ivc_champva/vha_10_7959f_2.rb (+42/-0)

  • modules/ivc_champva/app/services/ivc_champva/attachments.rb (+40/-0)

  • modules/ivc_champva/app/services/ivc_champva/file_uploader.rb (+67/-0)

  • modules/ivc_champva/app/services/ivc_champva/metadata_validator.rb (+72/-0)

  • modules/ivc_champva/app/services/ivc_champva/pdf_filler.rb (+52/-0)

  • modules/ivc_champva/app/services/ivc_champva/pdf_stamper.rb (+123/-0)

  • modules/ivc_champva/app/services/ivc_champva/s3.rb (+59/-0)

  • modules/ivc_champva/bin/rails (+12/-0)

  • modules/ivc_champva/config/routes.rb (+8/-0)

  • modules/ivc_champva/ivc_champva.gemspec (+20/-0)

  • modules/ivc_champva/lib/ivc_champva.rb (+8/-0)

  • modules/ivc_champva/lib/ivc_champva/engine.rb (+12/-0)

  • modules/ivc_champva/lib/ivc_champva/version.rb (+5/-0)

  • modules/ivc_champva/lib/tasks/forms.rake (+110/-0)

  • modules/ivc_champva/spec/models/vha_10_10d_spec.rb (+37/-0)

  • modules/ivc_champva/spec/models/vha_10_7959c_spec.rb (+47/-0)

  • modules/ivc_champva/spec/models/vha_10_7959f_1_spec.rb (+47/-0)

  • modules/ivc_champva/spec/models/vha_10_7959f_2_spec.rb (+38/-0)

  • modules/ivc_champva/spec/requests/v1/uploads_spec.rb (+51/-0)

  • modules/ivc_champva/spec/services/attachments_spec.rb (+55/-0)

  • modules/ivc_champva/spec/services/file_uploader_spec.rb (+93/-0)

  • modules/ivc_champva/spec/services/metadata_validator_spec.rb (+288/-0)

  • modules/ivc_champva/spec/services/pdf_filler_spec.rb (+41/-0)

  • modules/ivc_champva/spec/services/pdf_stamper_spec.rb (+85/-0)

  • modules/ivc_champva/spec/services/s3_spec.rb (+81/-0)

  • modules/ivc_champva/spec/spec_helper.rb (+8/-0)

  • spec/simplecov_helper.rb (+1/-0)

  • spec/spec_helper.rb (+1/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to 72706-create-ivcchampva-module/main/main March 26, 2024 19:13 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 72706-create-ivcchampva-module/main/main March 26, 2024 22:36 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 72706-create-ivcchampva-module/main/main March 27, 2024 18:00 Inactive
michaelclement
michaelclement previously approved these changes Mar 27, 2024
Copy link
Contributor

@michaelclement michaelclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lines up with previous implementation progress. It will be good to have a separate IVC module so we're not stepping on toes.

@va-vfs-bot va-vfs-bot temporarily deployed to 72706-create-ivcchampva-module/main/main March 27, 2024 18:21 Inactive
cloudmagic80
cloudmagic80 previously approved these changes Mar 27, 2024
Copy link
Contributor

@cloudmagic80 cloudmagic80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay. I ran it locally

@va-vfs-bot va-vfs-bot temporarily deployed to 72706-create-ivcchampva-module/main/main March 27, 2024 19:16 Inactive
@balexandr balexandr marked this pull request as ready for review March 27, 2024 22:31
@balexandr balexandr requested review from a team as code owners March 27, 2024 22:31
@va-vfs-bot va-vfs-bot temporarily deployed to 72706-create-ivcchampva-module/main/main March 29, 2024 01:23 Inactive
@stevenjcumming stevenjcumming merged commit 99fea10 into master Mar 29, 2024
19 of 20 checks passed
@stevenjcumming stevenjcumming deleted the 72706-create-ivcchampva-module branch March 29, 2024 19:28
stevenjcumming added a commit that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants