MHV-56068: Serialize tracking_list as 1-level array #16056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
MHV-56068/tracking-list-data-serialization/main/main
va-vfs-bot
temporarily deployed
to
MHV-56068/tracking-list-data-serialization/main/main
va-vfs-bot
temporarily deployed
to
MHV-56068/tracking-list-data-serialization/main/main
va-vfs-bot
temporarily deployed
to
MHV-56068/tracking-list-data-serialization/main/main
va-vfs-bot
temporarily deployed
to
MHV-56068/tracking-list-data-serialization/main/main
agravell047
approved these changes
Mar 26, 2024
stevenjcumming
approved these changes
Mar 27, 2024
10 tasks
agravell047
pushed a commit
that referenced
this pull request
Mar 28, 2024
* Add serlization for `tracking_list`, tests * Update/fix test for tracking_list and the first tracking item * Add trackingList item to openapi schema * Add separate PrescriptionTrackingItem schema, update PrescriptionDetail to reference
agravell047
added a commit
that referenced
this pull request
Mar 28, 2024
* udpated swagger docs/test * fixed linter and updated types * added new yml for rxRfRecord object * Codespaces native (#15935) * Add hybrid setup config * Various fixes * Improve startup * Don't try to bring app up in start * Add mockdata config * Improve startup * More QoL improvements * Improve startup * Add ruby lsp ext after start * Create log dir on start * Improvements * Change setup to facilitate ruby lsp extension installation * Remove manual extension installation * Fix startup script * More work on deps * Set user id when starting deps * More adjustments to startup scripts * simplify docker deps setup * Wait for the api to be ready before exiting the startup script * More QoL improvements * Change setup order * Add output for permissions set * Adjust permissions approach * One more adjustment * Belt & suspenders * More perms adjustment * Simplify startup * Add native setup * Change ruby setup to enable * Add hardware requirements * Add test DB config * Add docs * Update postgres version * Update redis version * Fix foreman output * Use different redis package * Minor debug output * Don't bother with starting the app * Improve test database config * Update doc * Remove host requirements * Only notify for port forwarding on 3000 * Allow access from localhost and shared github URLs. * Change ownership * Remove host header check This was obviated by the addition of the HostAuthorization middleware in Rails 6 * Add test DB setup to main local settings file * Update tests * API-32311 establish poa oas updates (#16005) * API-32311 establish poa oas updates * Updates OAS text * Updates Swagger Docs modified: modules/claims_api/app/swagger/claims_api/description/v2.md modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json modified: modules/claims_api/app/swagger/claims_api/v2/production/swagger.json * Updates for removed text * Fixes missed line removal * Adds missed docs text update * Adds 2122, 2122a, 212/vallidate, 2122a/validate and power-of-attorney/{id} endpoints to docs * Add pension specific sentry tag (#16040) * - Add pension specific sentry tag * - Add pension specific sentry tag * - Add pension specific sentry tag * - Add pension specific sentry tag --------- Co-authored-by: Scott Gorman <[email protected]> * dbex/77177: EVSS Migration - /generatePDF migration: Abstract references to EVSS /getpdf (#16080) * dbex/77177: add GeneratePdfProvider - FEATURE TOGGLE: disability_compensation_lighthouse_generate_pdf - evss - lighthouse stub(s) - unit tests * dbex/77177: add GeneratePdfProvider - fix linting and unit test * dbex/77177: add GeneratePdfProvider - fix linting and unit test * dbex/77177: add GeneratePdfProvider - added a unit test for evss service class checking * [Bugfix] Personal health care contacts: Selects only valid contact types (#16062) * Selects only valid contact types * Updating version of REDIS to 6.2 in the docker compose files. (#16090) * Authorized Ping Endpoint for Travel Pay API (#16089) * Add authorized_ping endpoint to BTSSS API * Adds specs for authorized ping endpoint, cleanup and bug fixes * Fixes for rubocop * Adds line comment --------- Co-authored-by: Athif Wulandana <[email protected]> * MBMS-61276 change UUID size and position on pre need form 40-10007 pdf (#16074) * [#MHV-54372] remove 556 transition feature flags (#15990) Co-authored-by: Alex Morgun <[email protected]> * removed cache busting for mobile rx (#16099) * removed cache busting for mobile rx * removed failing test for mobile * fixed gemfile * Bump json-schema from 4.2.0 to 4.3.0 Bumps [json-schema](https://github.com/voxpupuli/json-schema) from 4.2.0 to 4.3.0. - [Changelog](https://github.com/voxpupuli/json-schema/blob/master/CHANGELOG.md) - [Commits](voxpupuli/json-schema@v4.2.0...v4.3.0) --- updated-dependencies: - dependency-name: json-schema dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * update deprecated code * Added s3 check to specific appeals endpoint that use s3 (#16034) Co-authored-by: Matt Kelly <[email protected]> * Update Faker::IDNumber to Faker::IdNumber (#16102) * Api 33483 poa v2 signatures (#15406) * Make reg num required * Add sig to PDF * Add .first test * Handle duplicate reps by ID * Require rep_id in builder * Adding facility_type in CIE Logger util (#16083) Co-authored-by: kanchanasuriya <[email protected]> * MHV-56068: Serialize tracking_list as 1-level array (#16056) * Add serlization for `tracking_list`, tests * Update/fix test for tracking_list and the first tracking item * Add trackingList item to openapi schema * Add separate PrescriptionTrackingItem schema, update PrescriptionDetail to reference * Mobile: Remove logs (#16068) * Remove logs * rubocop * Add back logging that is occurring * Remove logging from tests --------- Co-authored-by: Tonksthebear <[email protected]> * Add additional logging in case of Pension errors (#16065) * Add additional logging in case of Pension errors * Fix lint errors * Handle no error message, fix test * Update codeowwners * Move logging to separate class * Update test * Fix lint * 76818: Change config for NodEmailLoaderJob to use a hash (#16109) * 79457 handle ICN for OH data (#16119) * fixed linter issues * added changes to openapi_merged.yaml --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Adrian Rollett <[email protected]> Co-authored-by: Rockwell Windsor Rice <[email protected]> Co-authored-by: Scott <[email protected]> Co-authored-by: Scott Gorman <[email protected]> Co-authored-by: Aurora <[email protected]> Co-authored-by: Richard Davis <[email protected]> Co-authored-by: Joshua Backfield <[email protected]> Co-authored-by: Athif Wulandana <[email protected]> Co-authored-by: Athif Wulandana <[email protected]> Co-authored-by: Adam Antonioli <[email protected]> Co-authored-by: Alex Morgun <[email protected]> Co-authored-by: Alex Morgun <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lindsey Hattamer <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: Matt Kelly <[email protected]> Co-authored-by: stevenjcumming <[email protected]> Co-authored-by: Austin Covrig <[email protected]> Co-authored-by: kanchanasuriya <[email protected]> Co-authored-by: kanchanasuriya <[email protected]> Co-authored-by: Daniel Cloud <[email protected]> Co-authored-by: Jason C <[email protected]> Co-authored-by: Tonksthebear <[email protected]> Co-authored-by: Tai Wilkin-Corraggio <[email protected]> Co-authored-by: dfong-adh <[email protected]> Co-authored-by: Gaurav Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tracking_listitems on a prescription object are serialized, so we get a single-dimensional array of items in thetrackingListJSONspec/factories/prescription_details.rbfor the multidimensional array structure we are flatteningPrescriptionTrackingItemRelated issue(s)
Testing done
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?