[MHV-55400]: medications shipped tracking #28827
Conversation
va-vfs-bot
temporarily deployed
to
master/MHV-55400/medications-shipped-tracking/main
updated fixtures for tracking
va-vfs-bot
temporarily deployed
to
master/MHV-55400/medications-shipped-tracking/main
added e2e test for shipped Rx on Refill Page
va-vfs-bot
temporarily deployed
to
master/MHV-55400/medications-shipped-tracking/main
va-vfs-bot
temporarily deployed
to
master/MHV-55400/medications-shipped-tracking/main
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
| <> | ||
| <br /> | ||
| <span data-testid={`medications-last-shipped-${idx}`}> | ||
| <i className="fas fa-truck vads-u-margin-right--1p5" /> |
| @@ -166,7 +166,7 @@ const VaPrescription = prescription => { | |||
| className="vads-u-margin--0 vads-u-margin-bottom--1" | |||
| data-testid="shipped-on" | |||
| > | |||
| {dateFormat(shippedOn?.[i]?.completeDateTime)} | |||
| {dateFormat(latestTrackingStatus?.completeDateTime)} | |||
There was a problem hiding this comment.
are we supposed to be using the index here?
There was a problem hiding this comment.
The code change on line 25, const latestTrackingStatus = prescription?.trackingList?.[0]; pulls an object, the first item out of the trackingList array.
We updated the vets-api serialization to remove the unnecessary levels of nesting, so the API will serve a 1-level array.
| "refillRemaining": 1, | ||
| "facilityName": "SLC10 TEST LAB", | ||
| "orderedDate": "2023-08-27T04:00:00.000Z", | ||
| "quantity": 1, | ||
| "expirationDate": "2024-08-27T04:00:00.000Z", | ||
| "dispensedDate": "2023-08-29T04:00:00.000Z", | ||
| "dispensedDate": "September 24, 2023", | ||
| "stationNumber": "979", |
There was a problem hiding this comment.
what was the reason for the format change?
There was a problem hiding this comment.
Time does not show in the UI and I used a fixture file that has tracking info for the refill history.
There was a problem hiding this comment.
Do we actually expect the API to return a date in that format? I'd expect a a consistent format from the backend APIs...
There was a problem hiding this comment.
Made the suggested changes and pushed the updated one.
updated the date format and assertion
RajiVenkatesh18
dismissed stale reviews from agravell047 and vmenshutin-bylight
via
b458ca8
va-vfs-bot
temporarily deployed
to
master/MHV-55400/medications-shipped-tracking/main
va-vfs-bot
temporarily deployed
to
master/MHV-55400/medications-shipped-tracking/main
assertion fixes for shipped and dispensed information on UI
va-vfs-bot
temporarily deployed
to
master/MHV-55400/medications-shipped-tracking/main
va-vfs-bot
temporarily deployed
to
master/MHV-55400/medications-shipped-tracking/main
Summary
/my-health/medications/refill, with a truck iconRelated issue(s)
Related PR
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
MHV Medications
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?