ClamAV in Containers #15965
ClamAV in Containers #15965
Conversation
Generated by 🚫 Danger |
| ENV['CLAMD_TCP_HOST'] = Settings.clamav.host | ||
| ENV['CLAMD_TCP_PORT'] = Settings.clamav.port |
There was a problem hiding this comment.
Do you have these saved in the RI settings.yml? I think that's somewhere over in the devops repo.
There was a problem hiding this comment.
Ah nvm, I guess if not defined, It'll use settings.yml
There was a problem hiding this comment.
Yeah, it's just in the settings.yml file
|
I would recommend moving over some of the README info around using clam locally from the k8s branch to master also. Specifically these two places |
I have a separate PR for the doc changes (although it might need some more updating) |
|
For some reason the coverage report isn't being uploaded to /coverage
|
* ClamAV in Containers (#15965) * use clamav container for local development and review instances * rubocop formatting & CODEOWNERS * fix Dockerfile * update CODEOWNERS and docker-compose version for review instances * change docker-compose verions for review * fix review ports * update github workflows to match k8s * update github workflows * update code_checks for docker compose for tests * add bundle exec to setup db step in audit service tags * reset db in docker compose review & update audit service tag docker services * remove clamd and freshclam from procfile * add sidekiq enterprise license to test env var * set sidekiq license to docker build args * update makefile to work with new docker services * add clamav host & port to settings * add restart services to docker-compose review * Added virus scan to uploads spec (#16393) * Added virus scan to uploads spec * Fixing Virus scan spec * resolve merge conflict * change directory from /app to /srv/vets-api/src * use previous master version for RI + clam containers * add USER_ID to RI docker-compose * set working directory back to app * minor clean up with new line EOF & remove k8s deploy related code * update makefile up command with foreman * fix docker-compose clamav new line * more cleanup and rubocop formatting * remove redis ports from docker-compose test * update redis port * revert docker-compose test to original master * update api service name to web * rubocop formatting * add Procfile to CODEOWNERS * update CODEOWNERS * add secret and pki volumes back to RI * add some settings in review docker-compose * fix merge conflict mistake in Dockerfile * update dockerfile ruby version --------- Co-authored-by: Rachal Cassity <[email protected]> * delete code checks yml --------- Co-authored-by: Rachal Cassity <[email protected]>
This reverts commit 0857270.
* master: (33 commits) [DBX-74810] Add flipper with LH BI api for 4142 (#16483) upadte param dig call (#16570) 98 add code to poll average days (#16471) 8147 claim model (#16525) Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548) Revert "ClamAV in Containers (#15965)" (#16557) Dangerfile updates for db migration (#16511) API-35829-error_handling (#16522) add loggers to see what dd api call is doing in staging (#16539) 8440: fix appointments contract schema (#16528) ClamAV in Containers (#15965) Protect against calling `.any?` on a non-array (#16547) BE | Ask VA Api: Refactor classes and specs (#16542) Added '10-10EZR' to the list of freeze schemas (#16478) Add prefill for 10-7959c (#16448) Bump shrine from 3.5.0 to 3.6.0 (#16532) change limit on place and location. update question number (#16537) Add words_to_remove for simple forms 21-0966 (#16477) updgrade sidekiq and super_diff (#16536) BE | Ask Va Api: Update `Inquiries::Creator` `Correspondences::Creator` Error Handling (#16529) ...
* prefer pdftk-java with debian bookworm * 8440: fix appointments contract schema (#16528) * add loggers to see what dd api call is doing in staging (#16539) * API-35829-error_handling (#16522) * Adds error handling for new synchronous endpoint. Iterates through errors and adds them to the ecss_response on the claim. Adds to the retry? method to check the evss_response for the error key. * Addressese PR suggestions * REmoves error message, and uses evss_response on the claim instead. * Adds a save rigt after updating the status on the claim * Adds several tests * Alters a test to more accurately test the scenario IRL * Dangerfile updates for db migration (#16511) * Revert "ClamAV in Containers (#15965)" (#16557) This reverts commit 0857270. * Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548) * add cause field to disabilities array * another flipper fix * remove debug comment * add comment for future engs * tests * nil check for input_disability * break from loop, not break from method * 8147 claim model (#16525) --------- Co-authored-by: Kris Pethtel <[email protected]> Co-authored-by: s-caso <[email protected]> Co-authored-by: Jennica Stiehl <[email protected]> Co-authored-by: Rebecca Tolmach <[email protected]> Co-authored-by: Rachal Cassity <[email protected]> Co-authored-by: Seth Darr <[email protected]> Co-authored-by: Andrew Herzberg <[email protected]>
Summary
This is an early step to replace review instances with preview environments. This is also an early step in merging k8s into master.
clam_scanwithclamav-clientsettings.local.ymlRelated issue(s)
Testing done
Acceptance criteria