Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ClamAV in Containers" #16557

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Revert "ClamAV in Containers" #16557

merged 1 commit into from
Apr 29, 2024

Conversation

RachalCassity
Copy link
Member

Reverts #15965

@RachalCassity RachalCassity requested review from a team as code owners April 29, 2024 21:14
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: Procfile

@github-actions GitHub Actions
Copy link

1 Error
🚫 This PR changes 681 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • .github/CODEOWNERS (+3/-12)

  • .github/workflows/audit_service_tags.yml (+6/-5)

  • .github/workflows/code_checks.yml (+6/-5)

  • .gitignore (+0/-4)

  • Dockerfile (+88/-51)

  • Gemfile (+1/-1)

  • Makefile (+13/-6)

  • Procfile (+2/-0)

  • app/uploaders/uploader_virus_scan.rb (+3/-4)

  • bin/fake_clamdscan (+5/-0)

  • config/clamd.conf (+2/-4)

  • config/freshclam.conf (+1/-1)

  • config/initializers/clamav.rb (+0/-6)

  • config/initializers/clamscan.rb (+5/-0)

  • config/settings.local.yml.example (+4/-4)

  • config/settings.yml (+0/-7)

  • docker-compose-clamav.yml (+0/-10)

  • docker-compose-deps.yml (+1/-8)

  • docker-compose.review.yml (+39/-54)

  • docker-compose.test.yml (+2/-1)

  • docker-compose.yml (+34/-46)

  • lib/clamav/commands/patch_scan_command.rb (+0/-43)

  • lib/clamav/patch_client.rb (+0/-76)

  • lib/common/file_helpers.rb (+0/-17)

  • lib/common/virus_scan.rb (+4/-12)

  • lib/shrine/plugins/validate_virus_free.rb (+3/-5)

  • spec/lib/shrine/plugins/validate_virus_free_spec.rb (+23/-9)

  • spec/models/persistent_attachments/dependency_claim_spec.rb (+2/-5)

  • spec/models/persistent_attachments/lgy_claim_spec.rb (+2/-5)

  • spec/models/persistent_attachments/pension_burial_spec.rb (+2/-5)

  • spec/requests/claim_documents_spec.rb (+2/-2)

  • spec/simplecov_helper.rb (+1/-0)

  • spec/spec_helper.rb (+1/-0)

  • spec/support/uploader_helpers.rb (+7/-1)

  • spec/uploaders/uploader_virus_scan_spec.rb (+7/-3)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@RachalCassity RachalCassity merged commit 8620765 into master Apr 29, 2024
18 of 20 checks passed
@RachalCassity RachalCassity deleted the revert-15965-sjc-clamav-container branch April 29, 2024 21:29
RachalCassity added a commit that referenced this pull request Apr 29, 2024
@RachalCassity
Revert "ClamAV in Containers (#15965)" (#16557) (#16559)
a50ba4d 
This reverts commit 0857270.
stevenjcumming pushed a commit that referenced this pull request Apr 30, 2024
@RachalCassity @stevenjcumming
Revert "ClamAV in Containers (#15965)" (#16557)
5e82959 
This reverts commit 0857270.
gabezurita added a commit that referenced this pull request Apr 30, 2024
@gabezurita
Merge branch 'master' into arf.80297/ARP-OGC-number
aedce15 
* master: (33 commits)
  [DBX-74810] Add flipper with LH BI api for 4142 (#16483)
  upadte param dig call (#16570)
  98 add code to poll average days (#16471)
  8147 claim model (#16525)
  Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548)
  Revert "ClamAV in Containers (#15965)" (#16557)
  Dangerfile updates for db migration (#16511)
  API-35829-error_handling (#16522)
  add loggers to see what dd api call is doing in staging (#16539)
  8440: fix appointments contract schema (#16528)
  ClamAV in Containers (#15965)
  Protect against calling `.any?` on a non-array (#16547)
  BE | Ask VA Api: Refactor classes and specs (#16542)
  Added '10-10EZR' to the list of freeze schemas (#16478)
  Add prefill for 10-7959c (#16448)
  Bump shrine from 3.5.0 to 3.6.0 (#16532)
  change limit on place and location. update question number (#16537)
  Add words_to_remove for simple forms 21-0966 (#16477)
  updgrade sidekiq and super_diff (#16536)
  BE | Ask Va Api:  Update `Inquiries::Creator` `Correspondences::Creator` Error Handling (#16529)
  ...
stevenjcumming added a commit that referenced this pull request May 1, 2024
@stevenjcumming @kpethtel
@s-caso @stiehlrod @rmtolmach @RachalCassity @sethdarragile6 @aherzberg
Update pdftk related documentation (#16546)
3c2d8c7 
* prefer pdftk-java with debian bookworm

* 8440: fix appointments contract schema (#16528)

* add loggers to see what dd api call is doing in staging (#16539)

* API-35829-error_handling (#16522)

* Adds error handling for new synchronous endpoint. Iterates through errors and adds them to the ecss_response on the claim. Adds to the retry? method to check the evss_response for the error key.

* Addressese PR suggestions

* REmoves error message, and uses evss_response on the claim instead.

* Adds a save rigt after updating the status on the claim

* Adds several tests

* Alters a test to more accurately test the scenario IRL

* Dangerfile updates for db migration (#16511)

* Revert "ClamAV in Containers (#15965)" (#16557)

This reverts commit 0857270.

* Toxic Exposure: Save TE "Add Conditions" fields for future transformation (#16548)

* add cause field to disabilities array

* another flipper fix

* remove debug comment

* add comment for future engs

* tests

* nil check for input_disability

* break from loop, not break from method

* 8147 claim model (#16525)

---------

Co-authored-by: Kris Pethtel <[email protected]>
Co-authored-by: s-caso <[email protected]>
Co-authored-by: Jennica Stiehl <[email protected]>
Co-authored-by: Rebecca Tolmach <[email protected]>
Co-authored-by: Rachal Cassity <[email protected]>
Co-authored-by: Seth Darr <[email protected]>
Co-authored-by: Andrew Herzberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjcumming stevenjcumming stevenjcumming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RachalCassity @va-vsp-bot @stevenjcumming