Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19805: Adds new statuses (#19881) #20121

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

jilladams
Copy link
Contributor

@jilladams jilladams commented Dec 17, 2024

  • VACMS-19805: Adds new statuses

  • VACMS-19805: Brings Vet Center - Outstation in line with other facilities

  • Revert "VACMS-19805: Brings Vet Center - Outstation in line with other facilities"

This reverts commit 1f15486.

Description

Relates to #issueid. (or closes?)

Testing done

Manual

Screenshots

Facility node:edit showing status

Screenshot 2024-12-18 at 9 45 25 AM

POST API Queue with new statuses

Screenshot 2024-12-18 at 9 45 16 AM

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

* VACMS-19805: Adds new statuses

* VACMS-19805: Brings Vet Center - Outstation in line with other facilities

* Revert "VACMS-19805: Brings Vet Center - Outstation in line with other facilities"

This reverts commit 1f15486.

* VACMS-19805: Removes non-relevant change

* VACMS-19805: Aligning more info label and help

* VACMS-19805: Reverts changes to VBA

* VACMS-19805: Updates operating status more info to match others.
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 23:24 Destroyed
Copy link

Checking composer.lock changes...

Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 14:13 Destroyed
Copy link

Checking composer.lock changes...

@omahane omahane marked this pull request as ready for review December 18, 2024 17:47
@omahane omahane requested a review from a team as a code owner December 18, 2024 17:47
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 17:48 Destroyed
Copy link

Checking composer.lock changes...

Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the CMS changes on node:edit, node:view and POST API Queue. Looks ready to go.

@jilladams
Copy link
Contributor Author

@omahane cypress tests seem maybe stuck in pending. Yeah? Should I try rekicking again?

@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Dec 18, 2024
@omahane
Copy link
Contributor

omahane commented Dec 18, 2024

@omahane cypress tests seem maybe stuck in pending. Yeah? Should I try rekicking again?

No, let's let it go. I updated the branch, so it needed to run all tests again.

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-est

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

@omahane
Copy link
Contributor

omahane commented Dec 18, 2024

@jilladams I just looked and it seems like they are still running: https://pr20121-zeeeigrgae9djaliujipfwpr9ockav9o.ci.cms.va.gov/cypress/videos/platform/

@omahane omahane merged commit 67cb63f into main Dec 18, 2024
18 checks passed
@omahane omahane deleted the integration-operating-statuses branch December 18, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants