-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new operating status options to field_operating_status_facility #19805
Comments
@Agile6MSkinner @omahane I updated the ACs to include an explicit list of the Content Types that this field displays on. One of them that I almost forgot about is the IEF on the VAMC System Operating Status page. There's a backlog ticket to remove that IEF, but while it's still alive we should make sure it's accounted for. |
Final list of values has been added. Ready to be picked up. |
Can I propose the machine names? Temporary facility closure = temporary_closure |
@omahane I think the Drupal part of the test plan is done, it's aggressive. It goes through line 79 in the google sheet Let me know if you are able to review and see if it makes sense. @Agile6MSkinner if you are able to take a look as well I think that would also be helpful, thanks! |
Laura and I discussed the Test Plan of Doom (my words) and realized that she actually uncovered some inconsistencies that shouldn't be in the way operating status is presented on the form:
Laura also reminded me that we have the Facility Operating Status audit to check. |
After talking with Christian, I greatly simplified the Drupal piece of the test plan and made this more of a documentation of Operating Status functionality in Drupal, much simpler to review and understand. I will also make tickets (or find if we happen to have them already) for the 2 issues mentioned above and make sure those are tracked somewhere |
Update: I made the necessary config change for Vet Center - Outstation, so now all of the facility node's edit forms should behave the same (Operating status with the IEF is it's own little monster). |
|
Integration branch PR: #20121 |
Drupal PR merged today, and should deploy with tomorrow's daily deploy (Thurs 12/19). fysa @Agile6MSkinner @mmiddaugh |
Do not merge until launch plan step
Description
New options that we will provide editors for their facilities' operating status will need to be added to the values in field_operating_status_facility
**Final list
Engineering notes / background
The form display UX for showing or hiding the "More information" textarea is addressed in
va_gov_facilities/js/facility_status_details.es6.js
. Because it uses "normal" or NOT "normal" as the condition, it should only need to be tested and does not require a code change.Testing & QA
QA Test plan in ticket #19808
Acceptance criteria
The text was updated successfully, but these errors were encountered: