Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new operating status options to field_operating_status_facility #19805

Open
10 of 14 tasks
Agile6MSkinner opened this issue Nov 6, 2024 · 10 comments
Open
10 of 14 tasks
Assignees
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide VAMC CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices Vet Center CMS managed product owned by Facilities team

Comments

@Agile6MSkinner
Copy link

Agile6MSkinner commented Nov 6, 2024

Do not merge until launch plan step

Description

New options that we will provide editors for their facilities' operating status will need to be added to the values in field_operating_status_facility

**Final list

  • Normal services and hours (Existing)
  • Limited service and hours (Existing)
  • Closed (Existing)
  • Temporary facility closure (New)
  • Temporary location (New)
  • Virtual care only (New)
  • Coming soon (New)
  • Facility notice (Existing)

Engineering notes / background

The form display UX for showing or hiding the "More information" textarea is addressed in va_gov_facilities/js/facility_status_details.es6.js. Because it uses "normal" or NOT "normal" as the condition, it should only need to be tested and does not require a code change.

Testing & QA

QA Test plan in ticket #19808

  • Need to check the form UX to confirm that all statuses that are not "Normal" require a "More information" field to show.
  • Check the Operating Status post API queue payload content

Acceptance criteria

  • New options added to this field display on the relevant content types
    • nca_facility
    • health_care_local_facility
    • vba_facility
    • vet_center
    • vet_center_cap
    • vet_center_outstation
    • IEF on vamc_operating_status_and_alerts
  • All statuses that are not "Normal" require "More information" field to show (label= "Details")
    • Required
    • 300 character limit, with character counter displayed
  • Give LH the final new operating status values & machine names so they can prepare (trello card)
@Agile6MSkinner Agile6MSkinner changed the title Update API Push to LH for Operating Status Add new operating status options to field_operating_status_facility Nov 6, 2024
@jilladams jilladams added Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) labels Nov 6, 2024
@Agile6MSkinner Agile6MSkinner added VAMC CMS managed product owned by Facilities team Vet Center CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices and removed Needs refining Issue status labels Nov 6, 2024
@davidmpickett
Copy link
Contributor

davidmpickett commented Nov 6, 2024

@Agile6MSkinner @omahane I updated the ACs to include an explicit list of the Content Types that this field displays on. One of them that I almost forgot about is the IEF on the VAMC System Operating Status page. There's a backlog ticket to remove that IEF, but while it's still alive we should make sure it's accounted for.

Image

@Agile6MSkinner
Copy link
Author

Final list of values has been added. Ready to be picked up.

@eselkin
Copy link
Contributor

eselkin commented Nov 14, 2024

Can I propose the machine names?

Temporary facility closure = temporary_closure
Temporary location = temporary_location
Virtual care only = virtual_care
Coming soon = coming_soon

@laflannery
Copy link
Contributor

@omahane I think the Drupal part of the test plan is done, it's aggressive. It goes through line 79 in the google sheet Let me know if you are able to review and see if it makes sense.

@Agile6MSkinner if you are able to take a look as well I think that would also be helpful, thanks!

@omahane
Copy link
Contributor

omahane commented Nov 15, 2024

Laura and I discussed the Test Plan of Doom (my words) and realized that she actually uncovered some inconsistencies that shouldn't be in the way operating status is presented on the form:

  • Vet Center Outstation does not have Normal set as the default (as it should)
  • Operating Status IEF for Facility has operating status as a drop-down, instead of a radio button.

Laura also reminded me that we have the Facility Operating Status audit to check.

@laflannery
Copy link
Contributor

After talking with Christian, I greatly simplified the Drupal piece of the test plan and made this more of a documentation of Operating Status functionality in Drupal, much simpler to review and understand.

I will also make tickets (or find if we happen to have them already) for the 2 issues mentioned above and make sure those are tracked somewhere

@omahane
Copy link
Contributor

omahane commented Nov 15, 2024

Update: I made the necessary config change for Vet Center - Outstation, so now all of the facility node's edit forms should behave the same (Operating status with the IEF is it's own little monster).

@jilladams
Copy link
Contributor

We tested the new statuses with Adam from Lighthouse (LH) in their Sandbox environment, and they passed. Conversation in Slack. LH plans to deploy the changes to production on Monday.
https://dsva.slack.com/archives/C0FQSS30V/p1732312347334119

@jilladams
Copy link
Contributor

Integration branch PR: #20121

@jilladams
Copy link
Contributor

Drupal PR merged today, and should deploy with tomorrow's daily deploy (Thurs 12/19). fysa @Agile6MSkinner @mmiddaugh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) sitewide VAMC CMS managed product owned by Facilities team VBA for VBA facilities that are not Regional Offices Vet Center CMS managed product owned by Facilities team
Projects
None yet
Development

No branches or pull requests

6 participants