VACMS-17885: Create facility services links on VBA Facility page

[omahane]

Description

Relates to #17885

Testing done

Manually

Screenshots

QA steps

Set up QA Content Publisher

• As an admin, update the QA Content Editor
  • Assign the following roles
    • Content creator - VBA
    • Content editor
  • Assign the following Section
    • Portland VA Regional Benefit Office
    • Cheyenne VA Regional Benefit Office

Create a service in Portland VA Regional Benefit Office

• As QA Content Editor, go to the Portland VA Regional Benefit Office
• Click on Create a new service for this facility (opens in new window).
• Confirm that the Section is set to "Portland VA Regional Benefit Office"
• Confirm that the Facility is "Portland VA Regional Benefit Office"
• Create a new service (such as Disability compensation)
• Save the service
• Close the window

Review the Portland VA Regional Benefit Office facility services

• On the Portland VA Regional Benefit Office page, click on Manage existing services for this facility (opens in new window)
• Confirm that the VBA Facilities are listed, filtered for the Portland VA Regional Benefit Office

Create a service in Cheyenne VA Regional Benefit Office

• As QA Content Editor, go to the VA Regional Benefit Satellite Office at Sheridan VA Medical Center
• Click on Create a new service for this facility (opens in new window).
• Confirm that the Section is set to "Cheyenne VA Regional Benefit Office"
• Confirm that the Facility is "VA Regional Benefit Satellite Office at Sheridan VA Medical Center"
• Create a new service (such as Disability compensation)
• Save the service
• Close the window

Review the Cheyenne VA Regional Benefit Office facility services

• On the VA Regional Benefit Satellite Office at Sheridan VA Medical Center page, click on Manage existing services for this facility (opens in new window)
• Confirm that the VBA Facilities are listed, filtered for the VA Regional Benefit Satellite Office at Sheridan VA Medical Center

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[dsasser]

SHOULD...
...use a more structured approach to the markup here to support readability and ultimately translations. eg:

  $form["#fieldgroups"]["group_facility_services"]->format_settings["description"]['create'] = [
    '#title' => $this->t('Create a new service for this facility (opens in new window)'),
    '#type' => 'link',
    '#url' => // the url,
    '#prefix' => '<p>',
    '#suffix' => '</p>',
  ];
  $form["#fieldgroups"]["group_facility_services"]->format_settings["description"]['manage'] = [
    '#title' => $this->t('Manage existing services for this facility (opens in new window)'),
    '#type' => 'link',
    '#url' => // the url,
    '#prefix' => '<p>',
    '#suffix' => '</p>',
  ];

[omahane]

I tried to implement this, but kept getting errors that appear to be related to how ['description'] is expecting a string, not an array.

I wrapped the link text in a t() and made it all a little more readable.

$create_service_url = "/node/add/vba_facility_service?field_administration=$section_tid&field_office=$facility_nid";
    $create_service_text = $this->t('Create a new service for this facility (opens in new window)');
    $encoded_facility_name = urlencode($entity->title->value);
    $manage_services_url = "/admin/content?title=$encoded_facility_name&type=vba_facility_service&moderation_state=All&owner=All";
    $manage_services_text = $this->t('Manage existing services for this facility (opens in new window)');

    if (isset($form["#fieldgroups"]["group_facility_services"]->format_settings["description"])) {
      $form["#fieldgroups"]["group_facility_services"]->format_settings["description"] = "
        <p><a href='$create_service_url' target='_blank'>$create_service_text</p>
        <p><a href='$manage_services_url' target='_blank'>$manage_services_text</p>
        ";
    }

[dsasser]

Looks good. Both create and manage links are working per ACs.

[davidmpickett]

Works as expected on Node:Edit. Would adding it to Node:View be a significant additional lift?

[omahane]

Works as expected on Node:Edit. Would adding it to Node:View be a significant additional lift?

Yes, it would. Adding stuff to node:view and node:edit is different enough to make this a scope change.