Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17073: Removing allowed formats from json. #17625

Closed

Conversation

anantais
Copy link
Contributor

Description

Closes to #17073

Testing done

Verified that allowed_formats was removed from composer.json

Screenshots

Screenshot 2024-03-25 at 3 50 56 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Verify that the following line has been removed from composer.json
    "drupal/allowed_formats": "^3.0",

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@anantais anantais linked an issue Mar 25, 2024 that may be closed by this pull request
7 tasks
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 25, 2024 19:52 Destroyed
@anantais anantais requested a review from edmund-dunn March 25, 2024 19:52
@anantais anantais changed the title VACMS-17073: Removing allowed formats form json. VACMS-17073: Removing allowed formats from json. Mar 25, 2024
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Mar 25, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 01:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 13:32 Destroyed
@anantais anantais force-pushed the 17073-upgrade-the-allowed_formats-module-to-v300-p3 branch from 727dd8a to 854591c Compare March 26, 2024 13:40
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 13:41 Destroyed
@anantais anantais force-pushed the 17073-upgrade-the-allowed_formats-module-to-v300-p3 branch from 854591c to ba74dab Compare March 26, 2024 14:04
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 14:04 Destroyed
@anantais anantais force-pushed the 17073-upgrade-the-allowed_formats-module-to-v300-p3 branch from fb0a9cf to f8a3c7f Compare March 26, 2024 14:33
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 14:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 14:37 Destroyed
@anantais anantais force-pushed the 17073-upgrade-the-allowed_formats-module-to-v300-p3 branch from 24b86f4 to ba74dab Compare March 26, 2024 14:42
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 14:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 14:46 Destroyed
@anantais anantais closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the allowed_formats module to v3.0.0
2 participants