Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the allowed_formats module to v3.0.0 #17073

Closed
1 of 7 tasks
Tracked by #17331 ...
edmund-dunn opened this issue Jan 29, 2024 · 9 comments · Fixed by #17548, #17635 or #17650
Closed
1 of 7 tasks
Tracked by #17331 ...

Upgrade the allowed_formats module to v3.0.0 #17073

edmund-dunn opened this issue Jan 29, 2024 · 9 comments · Fixed by #17548, #17635 or #17650
Assignees
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area

Comments

@edmund-dunn
Copy link
Contributor

edmund-dunn commented Jan 29, 2024

User Story or Problem Statement

The functionality for the allowed_formats module is now contained in Drupal core. As such, it needs to be updated and removed. See https://www.drupal.org/project/allowed_formats for more information.

Description or Additional Context

Steps for Implementation

  1. When your site is upgrading to Drupal 10.1, install also the 3.0.0 release of the module.
  2. Running database updates will move the allowed formats from module's third-party settings to the field config settings.
  3. Now it's time to re-export your configuration in the config sync directory, in order to update the affected YAML files.

Acceptance Criteria

  • PR 1: Module updated and deployed.
  • PR 2: Config exported and deployed, module disabled.
  • PR 3: Module removed from composer.json.

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@edmund-dunn edmund-dunn added Drupal engineering CMS team practice area Needs refining Issue status CMS Team CMS Product team that manages both editor exp and devops labels Jan 29, 2024
@BerniXiongA6
Copy link

@edmund-dunn and Amanda to discuss this ticket to decide who will take this work on -- Edmund can you help flesh out ticket details and preliminary ACs for this ahead of your sync? cc: @maortiz-27-80

@maortiz-27-80
Copy link

@edmund-dunn and Amanda met this afternoon 01/31 to discuss the ticket. This upgrade is NON-urgent. The A/C has been updated with the PRs. The new team will take on this task and the current team will not work on this in Sprint 103. cc: @BerniXiongA6 @michelle-dooley @EWashb

@gracekretschmer-metrostar

@anantais what is your progress on this work?

@anantais
Copy link
Contributor

anantais commented Mar 18, 2024

Branch created for the issue. Working on first code release.

@gracekretschmer-metrostar

Edmund's feedback: this will happen over 3 days because of daily deploys.

@gracekretschmer-metrostar

In flight right now. Likely will be done by end of sprint.

@anantais
Copy link
Contributor

Part 2 should be deploying today. It went out with part of another ticket - #17593 Hopefully I can finish this up by Monday.

@anantais
Copy link
Contributor

Reopening to fix an issue.

@edmund-dunn edmund-dunn linked a pull request Mar 27, 2024 that will close this issue
20 tasks
@edmund-dunn
Copy link
Contributor Author

We need to keep the module. There was additional functionality that we need to maintain, not directly related to allowed formats. It has to do with hiding the text format field form editors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment