Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-0000: No VBA change #17224

Closed
wants to merge 8 commits into from
Closed

VACMS-0000: No VBA change #17224

wants to merge 8 commits into from

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Feb 13, 2024

Description

Relates to #issueid. (or closes?)

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

dependabot bot and others added 8 commits February 13, 2024 12:34
@dependabot @omahane
Bump drupal/codit_menu_tools from 1.0.0-alpha5 to 1.0.1 (#17203)
5558a09 
Bumps drupal/codit_menu_tools from 1.0.0-alpha5 to 1.0.1.

---
updated-dependencies:
- dependency-name: drupal/codit_menu_tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @omahane
Bump int128/datadog-actions-metrics from 1.79.0 to 1.80.0 (#17207)
993c209 
Bumps [int128/datadog-actions-metrics](https://github.com/int128/datadog-actions-metrics) from 1.79.0 to 1.80.0.
- [Release notes](https://github.com/int128/datadog-actions-metrics/releases)
- [Commits](int128/datadog-actions-metrics@af1a1a7...2ca3c09)

---
updated-dependencies:
- dependency-name: int128/datadog-actions-metrics
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @omahane
Bump reviewdog/action-eslint from 1.22.0 to 1.23.0 (#17206)
65fd5b7 
Bumps [reviewdog/action-eslint](https://github.com/reviewdog/action-eslint) from 1.22.0 to 1.23.0.
- [Release notes](https://github.com/reviewdog/action-eslint/releases)
- [Commits](reviewdog/action-eslint@5deb8e2...b3c5aa2)

---
updated-dependencies:
- dependency-name: reviewdog/action-eslint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @omahane
Bump reviewdog/action-stylelint from 1.18.1 to 1.22.1 (#17204)
67c5d92 
Bumps [reviewdog/action-stylelint](https://github.com/reviewdog/action-stylelint) from 1.18.1 to 1.22.1.
- [Release notes](https://github.com/reviewdog/action-stylelint/releases)
- [Commits](reviewdog/action-stylelint@548276a...eadef3f)

---
updated-dependencies:
- dependency-name: reviewdog/action-stylelint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@swirtSJW @omahane
VACMS-16233 Reorder VAMC menus (#17189)
8e9eec9 
* VACMS-4943 Remove VA Leavenworh menu. It is empty and not used.

* VACMS-4943 Remove VA Topeka menu. It is empty and not used.

* VACMS-14683 Bring in scripts changes from 14683.

* VACMS-16233 Add reorder VAMC System menu items.
@dependabot @edmund-dunn @omahane
Bump va-gov/content-build from 0.0.3437 to 0.0.3438 (#17180)
d8995b4 
Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3437 to 0.0.3438.
- [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases)
- [Commits](department-of-veterans-affairs/content-build@v0.0.3437...v0.0.3438)

---
updated-dependencies:
- dependency-name: va-gov/content-build
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Edmund Dunn <[email protected]>
@ndouglas @omahane
Update tugboat.md
1d2364f
@dependabot @omahane
Bump va-gov/content-build from 0.0.3438 to 0.0.3439 (#17217)
5b6d0bb 
Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3438 to 0.0.3439.
- [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases)
- [Commits](department-of-veterans-affairs/content-build@v0.0.3438...v0.0.3439)

---
updated-dependencies:
- dependency-name: va-gov/content-build
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 13, 2024 18:37 Destroyed
@github-actions github-actions bot changed the title Vacms 0000 no vba change VACMS-0000: no vba change Feb 13, 2024
@omahane omahane changed the title VACMS-0000: no vba change VACMS-0000: No VBA change Feb 13, 2024
@omahane omahane mentioned this pull request Feb 13, 2024
Merged
33 tasks
@omahane omahane closed this Feb 13, 2024
@omahane omahane deleted the VACMS-0000-no-vba-change branch February 16, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omahane @va-cms-bot @swirtSJW @ndouglas