Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17221: Restore field_intro_text #17222

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Feb 13, 2024

Description

Relates to #17221

Testing done

Manually

Screenshots

Screenshot 2024-02-13 at 10 52 25 AM

QA steps

Set up the editor

  • Log in as an admin
  • Assign the user QA Content Publisher to the following role:
    • Content creator - VBA
  • Assign the user to the following section:
    • Cheyenne VA Regional Benefit Office

Test the preview

Release content

  • Log in as an admin
  • Go to Release Content
  • Click Release Content
  • After a 3 - 4 minutes, click View build log
  • Confirm that the following doesn't appear in the logs, under Beginning GraphQL queries with parallelization at 15 requests...
Error with GetVbaFacility__slice1. Scroll up for the GraphQL query that has an error:

[
  {
    "message": "Cannot query field \"fieldIntroText\" on type \"NodeVbaFacility\".",
    "extensions": {
      "category": "graphql"
    },
    "locations": [
      {
        "line": 52,
        "column": 11
      }
    ]
  }
]

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 13, 2024 16:47 Destroyed
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Feb 13, 2024
@omahane omahane changed the title VACMS-17221 Restore field_intro_text VACMS-17221: Restore field_intro_text Feb 13, 2024
@omahane
Copy link
Contributor Author

omahane commented Feb 13, 2024

Making this PR ready for review is blocked by an issue I identified on Slack.

@omahane
Copy link
Contributor Author

omahane commented Feb 13, 2024

I created another PR that doesn't have the VBA facility changes but all other up to the present. It still had the same issue:
Screenshot 2024-02-13 at 1 16 19 PM

I am going to change the QA to not wait for the Release Content to finish, only to see that the field-related error did not reappear.

@omahane omahane marked this pull request as ready for review February 13, 2024 19:19
@omahane omahane requested a review from a team as a code owner February 13, 2024 19:19
@omahane omahane requested a review from swirtSJW February 13, 2024 19:20
Copy link
Contributor

@Becapa Becapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. QA steps pass without a GraphQL Error:

Screenshot 2024-02-13 at 3 38 45 PM

@omahane omahane merged commit abbd258 into main Feb 13, 2024
35 checks passed
@omahane omahane deleted the VACMS-17221-restore-field-intro-text branch February 13, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants