Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAMC-16959: editors can't save detail pages under Work with us #16975

Merged
merged 3 commits into from
Jan 24, 2024
Merged

VAMC-16959: editors can't save detail pages under Work with us #16975

merged 3 commits into from
Jan 24, 2024

Conversation

edmund-dunn
Copy link
Contributor

@edmund-dunn edmund-dunn commented Jan 23, 2024 •
edited
Loading

Description

Closes #16959.

Testing done

Tested locally.

Screenshots

CleanShot2024-01-23at10 23 44

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  1. Log in as victor.a.mctest
  2. Go to /node/6228/edit
  3. Click on Parent Link drop down
    • Validate that the "Work with us" option is enabled.
  4. Try to save as published
    • Validate that the node saves with no errors.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn linked an issue Jan 23, 2024 that may be closed by this pull request
VAMC editors can't save detail pages under Work with us #16959
Closed
1 task
@edmund-dunn edmund-dunn self-assigned this Jan 23, 2024
@edmund-dunn edmund-dunn requested a review from omahane January 23, 2024 18:30
@edmund-dunn edmund-dunn added CMS Team CMS Product team that manages both editor exp and devops Defect Something isn't working (issue type) Drupal engineering CMS team practice area Facilities Facilities products (VAMC, Vet Center, etc) labels Jan 23, 2024
@edmund-dunn edmund-dunn reopened this Jan 23, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 23, 2024 18:47 Destroyed
@edmund-dunn edmund-dunn requested review from olivereri and removed request for omahane January 24, 2024 19:15
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 24, 2024 19:37 Destroyed
@edmund-dunn edmund-dunn removed the Facilities Facilities products (VAMC, Vet Center, etc) label Jan 24, 2024
@edmund-dunn edmund-dunn merged commit 0ef8e57 into main Jan 24, 2024
18 of 19 checks passed
@edmund-dunn edmund-dunn deleted the 16959-vamc-editors-cant-save-detail-pages-under-work-with-us branch January 24, 2024 20:04
@jilladams
Copy link
Contributor

Noting from Slack in response to Marcia's request the feedback make it onto PR:
https://dsva.slack.com/archives/CT4GZBM8F/p1706127924852279?thread_ts=1706123175.181739&cid=CT4GZBM8F:

The concern is: there are rules defined in the VAMC Menu Custom Access config that say: /work-with-us should not allow children in the menu. So the fix in PR currently allows Editors to save the node, but it also allows creating children, which contradicts the config and isn't right per VAMC governance. It sounds like you all would like to ship the current fix and address that in a subsequent issue -- is that right?

swirtSJW added a commit that referenced this pull request Jan 24, 2024
@swirtSJW
Revert "VACMS-16959: enabled Work with us parent menu item (#16975)"
a476f9d 
This reverts commit 0ef8e57.

This commit bypassed the root cause of the issue and hardcoded a bypass.
This was referenced Jan 24, 2024
Merged
Closed
swirtSJW added a commit that referenced this pull request Jan 25, 2024
@swirtSJW
Revert "VACMS-16959: enabled Work with us parent menu item (#16975)"
9bffe31 
This reverts commit 0ef8e57.

This commit bypassed the root cause of the issue and hardcoded a bypass.
swirtSJW added a commit that referenced this pull request Jan 25, 2024
@swirtSJW
Revert "VACMS-16959: enabled Work with us parent menu item (#16975)"
b45afd2 
This reverts commit 0ef8e57.

This commit bypassed the root cause of the issue and hardcoded a bypass.
swirtSJW added a commit that referenced this pull request Jan 25, 2024
@swirtSJW
VACMS-17018 Resolve VAMC menu assignment issues. (#16994)
f8508b2 
* Revert "VACMS-16959: enabled Work with us parent menu item (#16975)"

This reverts commit 0ef8e57.

This commit bypassed the root cause of the issue and hardcoded a bypass.

* VACMS-16959 Resolve duplicate validators.

* VACMS-16959 Prevent clientside validation from being too greedy with menu.

* VACMS-16959 Fix bug of empty being locked down.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivereri olivereri olivereri approved these changes

Assignees

@edmund-dunn edmund-dunn

Labels
CMS Team CMS Product team that manages both editor exp and devops Defect Something isn't working (issue type) Drupal engineering CMS team practice area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VAMC editors can't save detail pages under Work with us
4 participants
@edmund-dunn @jilladams @olivereri @va-cms-bot