VACMS-15901: Removes facilities not in user sections

[omahane]

Description

Relates to #15901
Relates to #15391
Relates to #7538
Relates to #12737
Relates to #15906

Testing done

Manually
Cypress

Screenshots

VBA Facility Service (intended content type)

Events (an affected content type)

QA steps

What needs to be checked to prove this works?

• Create facility service as editor in Cheyenne VA Regional Benefit Office
  • Log in as "test_Chanelle18"
  • Create a VBA Facility service
  • Confirm that the Facility dropdown only shows facilities in the "Cheyenne VA Regional Benefit Office" section
  • Choose "VA Regional Benefit Satellite Office at Sheridan VA Medical Center" from the Facility dropdown
  • Choose "Home Loans" from the Service name dropdown
  • Save the node
  • Log out
• Edit facility as editor in Cheyenne and Columbia sections
  • Log in as "test_Lucy.Abernathy30"
  • Edit the "Home loans" service you just created
  • Confirm that the Facility dropdown only shows facilities in the Cheyenne and Columbia sections

What needs to be checked to prove it didn't break any related things?

• Spot-check one content type for each of the winnowed fields
  • Create an Event (to check field_listing)
    • Log in as "QA Content Publisher," an editor in only one section
      • Create an event
      • Confirm that you can only choose a facility in the user's section from the Where should the event be listed? dropdown.
    • Log in as "Victor.A.MCtest," an editor in the "Outreach hub" and other sections
    • Create an event
      • Confirm that you can only choose a facility in the user's sections or "Outreach and events: outreach events" from the Where should the event be listed? dropdown.
  • Create a VAMC Facility Health Service (to check field_facility_location)
    • As Victor.A.MCtest, create a VAMC Facility health service
    • Confirm that you can only choose a facility in one of the user's sections from the Facility dropdown.
  • Create a VAMC Detail Page (to check field_office)
    • As Victor.A.MCtest, create a VAMC Detail Page.
    • Confirm that you can only choose a VAMC system in one of the user's sections from the Related office or health care system dropdown.

Testing Google spreadsheet:
https://docs.google.com/spreadsheets/d/17WXvo_QAPvB02Xlm0_np1uQWy83u3dbfJnRxAQdG_h0/edit#gid=0

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[jilladams]

Tested as 3 different editors who have multiple section permissions: 2 that have 1 VAMC + Outreach Hub, and 1 that has 2 VAMC sections. In all 3 cases, the Section options match the Event listing options, and Event saved correctly. Just requested a content release for kicks, but the FE shouldn't have anything to do with the change here. So: LGTM.

The events I made:

https://pr16663-qymzgx6nhcrlbdd8ahjuxg5xqw6l4sff.ci.cms.va.gov/northeast-ohio-health-care/events/64718

• VA NE Ohio & Outreach Hub Sections
• Published to Outreach Hub also

https://pr16663-qymzgx6nhcrlbdd8ahjuxg5xqw6l4sff.ci.cms.va.gov/northern-arizona-health-care/events/64719

• VA Northern Arizona & Outreach Hub Sections

https://pr16663-qymzgx6nhcrlbdd8ahjuxg5xqw6l4sff.ci.cms.va.gov/bedford-health-care/events/64720

• VA Bedford & VA Boston Sections

[jilladams]

Added "Relates to" in ticket body to all the tickets we think we might be solving here. Each'll need to be verified by the relevant team, but this'll help with paper trail.

[swirtSJW]

This tests out flawlessly and code is precise. Great work @omahane

[swirtSJW]