Winnow Facility dropdown on VBA Facility Service to match editor's Workbench Access Section

[davidmpickett]

User Story or Problem Statement

When VBA Facility Service content type was first built, we didn't have enough sections set up under VBA to do any sort of winnowing of the Facility Drop Down list - #11197 (comment)

While QAing #11334, I discovered that as a local VBA editor assigned to the Cheyenne section, I can create a VBA Facility service for VBA Facilities in different sections

Steps for Implementation

• Update local_facilities_entity_reference_view to have a new display that is unique to VBA instead of just applying to VAMCs?
  • Append the parent name to the facility in the dropdown element.
• Update field_office on vba_facility_service to use an entity reference filter by view to use the display.
• If needed, update the javascript for VBA Facility
• Update the caching on the VBA user in va_gov_user

Acceptance Criteria

• A user with the role VBA - Content Creator can only create VBA Facility Services for Facilities that are in the same Section(s) as that User
• Cypress test(s) are created to account for this.

[mmiddaugh]

Does this account for the the Safari wrinkle documented in #12884?

[omahane]

Does this account for the the Safari wrinkle documented in #12884?

That is a different issue, having to do with the way Safari handles styling, which differs from Chrome, Firefox or Edge.

[davidmpickett]

Update from a call with @omahane and @swirtSJW:

• @omahane discovered that the core winnower code is not working as intended in places where it was already applied. Best theory on this is that the winnower was coded in a way that worked on a previous version of Drupal (possibly 7 or 8) and broke on a previous upgrade (not the D10 upgrade).
• In order to get the winnower to function correctly for VBA, he has to fix the core winnower issue, which may result in also fixing other winnower defects on various other places and will add winnower function to places it wasn't previously applied (but would likely benefit from it)
• Other tickets that might be fixed by this ticket
  • BE: Events: Filter "Where to list" dropdown to only calendars user has permission for #15391
  • Provide winnowed down list of Vet Centers in Vet Center - Community Access Point #7538
  • "Where should this be listed?" select lists on listing item content types are not filtered by section #12737
  • Prevent Vet Center editors from creating Services for Facilities outside of their section #15906

[davidmpickett]

@jilladams @xiongjaneg
TLDR of last comment - the impact of this ticket is likely larger than VBA and may involve cross-team code review. However, given the fact that this could close multiple outstanding defect tickets, seems like that is a good thing. It would be more effort for @omahane to try and restrict his work just to VBA.

[xiongjaneg]

tagging @mmiddaugh for awareness as we had discussed having some capacity on the Drupal side as Front end catches up on VBA work so a bit of scope creep may be appropriate on this and payoff in the long run

[omahane]

@xiongjaneg @jilladams I have notified Public Websites and have solicited their feedback on this change: #15391 (comment)

[jilladams]

Added tags for other products that'll be updated by this change.

[swirtSJW]

This is closed by #16663