Refresh Tugboat Preview ID cache from PR cache scope #16562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
commented
Dec 22, 2023
| uses: actions/github-script@d7906e4ad0b1822421a7e6a35d5ca353c962f410 # v6.4.1 | ||
| with: | ||
| github-token: ${{ secrets.LABEL_API_TOKEN }} |
There was a problem hiding this comment.
The default identity github-actions (bot) does not trigger the pull_request: labeled event. I'm not sure why this is but a PAT will trigger the event correctly. (I suspect this to be a github-actions bug)
Note the PAT needed these permissions:
- repo admin read/write
- issues read/write
- pull request read/write
The current fine-grained token has these permissions for va.gov-cms and va.gov-cms-test repos only.
JunTaoLuo
commented
Dec 22, 2023
| if: ${{ github.event.label.name == 'refresh-tugboat-cache' }} | ||
| steps: | ||
| - name: Refresh Preview ID | ||
| uses: actions/cache/restore@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3.3.1 |
There was a problem hiding this comment.
Due to cache scoping, actions/cache/restore will only work if triggered from some type of pull_request event.
JunTaoLuo
commented
Dec 22, 2023
| for (const pr of prs) { | ||
| if (cacheKeys.includes(`${{ runner.os }}-tugboat-preview-id-pr-${pr}`)) { | ||
| console.log(`Need to refresh: ${pr}`) | ||
| toRefresh.push(pr) | ||
| await github.rest.issues.addLabels({ |
There was a problem hiding this comment.
pull_request: label seems to be the least disruptive event. Alternatively we can use any of the other pull request events.
github-actions
bot
removed
the
refresh-tugboat-cache
ndouglas
approved these changes
Dec 22, 2023
github-actions
bot
added
the
CMS Team
JunTaoLuo
force-pushed
the
16561-refresh-cache-entries
branch
from
3c6ea45 to
dc9614d
Compare
GitHub Workflows (.github/workflows/*.yml)Have you...
|
5 tasks
JunTaoLuo
added a commit
that referenced
this pull request
Jan 24, 2024
This reverts commit 48de27e.
JunTaoLuo
added a commit
that referenced
this pull request
Jan 24, 2024
This reverts commit 48de27e.
32 tasks
JunTaoLuo
added a commit
that referenced
this pull request
Feb 2, 2024
* Revert "Add documentation for Tugboat GHA integration (#16739)" This reverts commit e5bce05. * Revert "Refresh Tugboat Preview ID cache from PR cache scope (#16562)" This reverts commit 48de27e. * Revert "Minimize PR overhead for non-code changes (#16279)" This reverts commit 176aa38. * Update documentation (#17123) * Test PR with documentation change * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #16561
Testing done
Tested in va.gov-cms-test using department-of-veterans-affairs/va.gov-cms-test#1469. The last two triggered refreshes were successful. Note the name of the workflow job was updated to clarify functionality.
Screenshots
QA steps
TBD
Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated Publishing