-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert GHA Tugboat integration #17007
Conversation
423993c
to
a9eb237
Compare
Given the disruptiveness of testing these changes and the fact that we know we had a working system under the prior model just a few weeks ago, I'm inclined to just do a code-level review on this. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit; I have no notes.
Yea I think that is fine, especially since I did test the webhooks after hours two days ago. |
71be6a9
to
854ef33
Compare
GitHub Workflows (.github/workflows/*.yml)Have you...
|
Description
Resolves #16884. This will revert the changes from #16279 #16562 and #16739. These changes will return to using webhook integration for Tugboat previews.
Testing done
Webhooks tested using the following steps with a test PR.
QA steps
Testing this change requires turning on the Tugboat webhook which will be disruptive since duplicate Tugboat previews will be created. When testing make an announcement in the CMS channel so other developers are aware of the issue and clean up duplicated previews once testing is done. To test this change, make a PR that targets this branch and perform the following actions which tests for routine PR actions including opening, updating, closing, reopening and merging.
As any user who can open PRs on this repo
16884-revert
. I recommend making a small documentation change that can be reverted in step 6.Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing