Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16241: Post-D10 Cleanup #16431

Merged
merged 11 commits into from
Dec 14, 2023
Merged

VACMS-16241: Post-D10 Cleanup #16431

merged 11 commits into from
Dec 14, 2023

Conversation

edmund-dunn
Copy link
Contributor

Description

Relates to #16241.

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  • If all automated testing passes this should be good to go.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn requested review from a team as code owners December 14, 2023 16:15
@edmund-dunn edmund-dunn self-assigned this Dec 14, 2023
@edmund-dunn edmund-dunn linked an issue Dec 14, 2023 that may be closed by this pull request
8 tasks
@edmund-dunn edmund-dunn requested a review from ndouglas December 14, 2023 16:15
@edmund-dunn edmund-dunn added CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area labels Dec 14, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 14, 2023 16:15 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 14, 2023 17:50 Destroyed
Copy link
Contributor

@ndouglas ndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved because I think the entity_diff_ui thing is broken because the .git directory is removed on the base preview 😩

@edmund-dunn edmund-dunn enabled auto-merge (squash) December 14, 2023 18:12
@edmund-dunn edmund-dunn disabled auto-merge December 14, 2023 18:12
@edmund-dunn edmund-dunn merged commit d5516ac into main Dec 14, 2023
14 of 18 checks passed
@edmund-dunn edmund-dunn deleted the 16241-post-d10-cleanup branch December 14, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Drupal engineering CMS team practice area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-D10 Cleanup
3 participants