Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: VACMS-13188 Set Beneficiaries to Unlimited Cardinality #16245

Merged
merged 9 commits into from
Dec 12, 2023
Merged

DNM: VACMS-13188 Set Beneficiaries to Unlimited Cardinality #16245

merged 9 commits into from
Dec 12, 2023

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Nov 29, 2023 •
edited by edmund-dunn
Loading

Description

Sets the Beneficiaries field in the "Audience and Topics" paragraph type to unlimited cardinality.

Relates to #13188

Testing done

Manual and automated cypress tests confirm that the checkboxes are now rendering vs radios.

Screenshots

Screenshot 2023-11-29 at 3 49 33 PM

QA steps

As a content admin

  1. Visit /node/add/support_resources_detail_page
    • Validate that the "Beneficiaries" options are checkboxes (formerly radios)

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@dsasser dsasser marked this pull request as draft November 29, 2023 23:51
@dsasser dsasser changed the title VACMS-13188 Set Beneficiaries to Unlimited Cardinality DNM: VACMS-13188 Set Beneficiaries to Unlimited Cardinality Nov 29, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2023 23:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 30, 2023 00:05 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 1, 2023 15:25 Destroyed
edmund-dunn
edmund-dunn approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated that checkboxes appear instead of radios. Easy peasy!

@chriskim2311 chriskim2311 mentioned this pull request Dec 8, 2023
Merged
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2023 17:00 Destroyed
@jilladams
Copy link
Contributor

Unblocked and can merge whenever we have time to update PR .

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 11, 2023 20:53 Destroyed
@dsasser
Copy link
Contributor Author

dsasser commented Dec 12, 2023

FE work is now in prod, so we are safe to merge:

Screenshot 2023-12-12 at 2 49 48 PM

@dsasser dsasser marked this pull request as ready for review December 12, 2023 22:50
@dsasser dsasser merged commit cbd6682 into main Dec 12, 2023
18 checks passed
@dsasser dsasser deleted the VACMS-13188-beneficiaries-unlimited-cardinality branch December 12, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmund-dunn edmund-dunn edmund-dunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsasser @jilladams @edmund-dunn @va-cms-bot