Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16099: Update logic to account for Beneficiary Tags change to a multi select #1821

Merged
merged 11 commits into from
Dec 11, 2023

Conversation

chriskim2311
Copy link
Contributor

@chriskim2311 chriskim2311 commented Dec 5, 2023

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

We have made changes to account for the beneficiary tag data to become a multi select array of data. This PR will be in support of the CMS changes for this PR

Related issue(s)

department-of-veterans-affairs/va.gov-cms#16099

Testing done

Testing was done exclusively in tugboat envs. We tested across multiple drupal templates that utilize beneficiary tag data.

checklist- Tugboat: https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-checklist
media_list_images- https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-image-list
media_list_videos - https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-video-list
step_by_step -https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-step-by-step
faq_multiple_q_a
q_a
support_resources_detail_page - https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-rs-page

Tugboat for testing content: https://pr16245-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/

Screenshots

What areas of the site does it impact?

Acceptance criteria

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/16099-update-beneficiary-tags December 5, 2023 01:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/16099-update-beneficiary-tags December 5, 2023 01:29 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/16099-update-beneficiary-tags December 5, 2023 06:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/16099-update-beneficiary-tags December 7, 2023 21:38 Inactive
@chriskim2311 chriskim2311 changed the title VACMS-16099: Update logic to account for tags change to a multi select VACMS-16099: Update logic to account for Beneficiary Tags change to a multi select Dec 7, 2023
@chriskim2311 chriskim2311 marked this pull request as ready for review December 8, 2023 00:23
@chriskim2311 chriskim2311 requested review from a team as code owners December 8, 2023 00:23
yarn.lock Outdated Show resolved Hide resolved
@dsasser
Copy link
Contributor

dsasser commented Dec 8, 2023

I spotted checked an existing R&S detail page with a single beneficiary value and it looks good:

Screenshot 2023-12-08 at 8 43 19 AM

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/16099-update-beneficiary-tags December 8, 2023 17:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/16099-update-beneficiary-tags December 8, 2023 23:51 Inactive
Chris Kim added 2 commits December 8, 2023 15:52
…-of-veterans-affairs/content-build into 16099-update-beneficiary-tags
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriskim2311 chriskim2311 merged commit d74c83c into main Dec 11, 2023
22 checks passed
@chriskim2311 chriskim2311 deleted the 16099-update-beneficiary-tags branch December 11, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants