-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-16099: Update logic to account for Beneficiary Tags change to a multi select #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/main/16099-update-beneficiary-tags
December 5, 2023 01:06
Inactive
va-vfs-bot
temporarily deployed
to
master/main/16099-update-beneficiary-tags
December 5, 2023 01:29
Inactive
va-vfs-bot
temporarily deployed
to
master/main/16099-update-beneficiary-tags
December 5, 2023 06:02
Inactive
va-vfs-bot
temporarily deployed
to
master/main/16099-update-beneficiary-tags
December 7, 2023 21:38
Inactive
chriskim2311
changed the title
VACMS-16099: Update logic to account for tags change to a multi select
VACMS-16099: Update logic to account for Beneficiary Tags change to a multi select
Dec 7, 2023
randimays
reviewed
Dec 8, 2023
va-vfs-bot
temporarily deployed
to
master/main/16099-update-beneficiary-tags
December 8, 2023 17:03
Inactive
va-vfs-bot
temporarily deployed
to
master/main/16099-update-beneficiary-tags
December 8, 2023 23:51
Inactive
…-of-veterans-affairs/content-build into 16099-update-beneficiary-tags
randimays
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ataker
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
We have made changes to account for the beneficiary tag data to become a multi select array of data. This PR will be in support of the CMS changes for this PR
Related issue(s)
department-of-veterans-affairs/va.gov-cms#16099
Testing done
Testing was done exclusively in tugboat envs. We tested across multiple drupal templates that utilize beneficiary tag data.
checklist- Tugboat: https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-checklist
media_list_images- https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-image-list
media_list_videos - https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-video-list
step_by_step -https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-step-by-step
faq_multiple_q_a
q_a
support_resources_detail_page - https://web-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/resources/this-is-my-rs-page
Tugboat for testing content: https://pr16245-yogrwem6nmyd3tzetq328pbv4nfmgb3q.demo.cms.va.gov/
Screenshots
What areas of the site does it impact?
Acceptance criteria