-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-10356 Add content validator for Preview URL links (#10356) #16086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
ndouglas
previously approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github-actions
bot
added
the
CMS Team
CMS Product team that manages both editor exp and devops
label
Nov 9, 2023
@ndouglas Oops, I didn't realize pushing a new commit to fix a comment dismisses your review. |
JunTaoLuo
force-pushed
the
VACMS-10356-Prevent-preview-links
branch
from
November 9, 2023 20:14
720a0da
to
46975eb
Compare
This reverts commit 3431e2838886a644b71ec50dc4b0f9c24ded305d.
JunTaoLuo
force-pushed
the
VACMS-10356-Prevent-preview-links
branch
from
November 13, 2023 15:11
46975eb
to
4bfd64b
Compare
ndouglas
approved these changes
Nov 13, 2023
@JunTaoLuo NP, some repos here have that branch protection rule set (like this one), some don't ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #10356.
Testing done
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
As user with ability to edit content:
Edit any node/page with rich text field, e.g. the VAMC system service description of a System Health Service.
Insert a link to a preview URL, e.g.
<a href="https://preview-staging.vfs.va.gov/example/path">Example Link!</a>
Try to save the document and be blocked by errors and validate that:
Edit any node/item with plain text field, e.g. description of a media image.
Add a link to a preview URL, e.g.
https://preview-staging.vfs.va.gov/example/path
Try to save the document and be blocked by errors and validate that:
Then validate Acceptance Criteria from issue
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing