VACMS-10356 Add content validator for Preview URL links (#10356) #16040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
force-pushed
the
VACMS-10356-Prevent-preview-links
branch
from
d7b8eaa to
ab7e4e6
Compare
JunTaoLuo
changed the title
This reverts commit 3431e2838886a644b71ec50dc4b0f9c24ded305d.
JunTaoLuo
force-pushed
the
VACMS-10356-Prevent-preview-links
branch
from
ab7e4e6 to
1262fe4
Compare
ndouglas
suggested changes
Nov 9, 2023
Comment on lines
+7
to
+20
| /** | ||
| * Checks that the text does not use any preview URLs as paths. | ||
| * | ||
| * In other words, we want to avoid things like this: | ||
| * | ||
| * `<a href="/https://www.va.gov/">VA.gov</a>` | ||
| * | ||
| * @Constraint( | ||
| * id = "PreventPreviewUrlsAsPathsInLinks", | ||
| * label = @Translation("Prevent Preview URLs as Paths in Links", context = "Validation"), | ||
| * type = { "string_long", "text_long" } | ||
| * ) | ||
| */ | ||
| class PreventPreviewUrlsAsPathsInLinks extends Constraint { |
There was a problem hiding this comment.
This appears to me to be somewhat misnamed -- it's not just blocking Preview URLs as paths, but as any href. Which is good, but it'd be better if the name matched 🙂
Request: Please rename this.
|
Thanks also for the good QA steps 🙂 |
ndouglas
reviewed
Nov 9, 2023
| /** | ||
| * Data provider. | ||
| */ | ||
| public function validateDataProvider() { |
There was a problem hiding this comment.
Praise: Good test cases 👍🏻
github-actions
bot
added
the
CMS Team
|
Closing in favor of #16086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #10356.
Testing done
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
As user with ability to edit content:
Edit any node/page with rich text field, e.g. the VAMC system service description of a System Health Service.
Insert a link to a preview URL, e.g.
<a href="https://preview-staging.vfs.va.gov/example/path">Example Link!</a>Try to save the document and be blocked by errors and validate that:
Edit any node/item with plain text field, e.g. description of a media image.
Add a link to a preview URL, e.g.
https://preview-staging.vfs.va.gov/example/pathTry to save the document and be blocked by errors and validate that:
Then validate Acceptance Criteria from issue
Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated Publishing