Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15891: Assign weights to content audit views' menu local tasks so tabs appear alphabetically #16085

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Nov 9, 2023

Description

This is a quick follow up to #15891 to address the order of menu tabs (menu local tasks) for content audit Views.

Because the menu tab order is defined using weights, and the weights of existing Views didn't allow for placing the new 'Page-specific Q&A' View alphabetically, several Views had to be updated.

Relates to #15891

Testing done

Manual.

Screenshots

Before:
Screenshot 2023-11-09 at 11 00 07 AM

After:
Screenshot 2023-11-09 at 10 59 11 AM

QA steps

As a content admin

  1. Visit /admin/content/audit/qa
    • Validate that the tabs are listed in alphabetical order

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 9, 2023 19:04 Destroyed
@dsasser dsasser mentioned this pull request Nov 9, 2023
3 tasks
@jilladams jilladams self-requested a review November 9, 2023 20:02
@dsasser dsasser merged commit 1f57037 into main Nov 9, 2023
15 checks passed
@dsasser dsasser deleted the VACMS-15891-update-tab-order branch November 9, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants