Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Q&A report workflow filter #15891

Closed
1 of 3 tasks
chri5tia opened this issue Oct 27, 2023 · 9 comments
Closed
1 of 3 tasks

Edit Q&A report workflow filter #15891

chri5tia opened this issue Oct 27, 2023 · 9 comments
Assignees
Labels
Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide Unplanned work Work that was introduced post-planning

Comments

@chri5tia
Copy link
Contributor

chri5tia commented Oct 27, 2023

Background

Work was performed by the Public Websites team in order to fix the issue wherein inaccurate Menu link breadcrumbs on the "Board of Veterans Appeals" page on prod > the “Manage a legacy VA appeal” link is causing hourly broken link alerts, which could possibly mask actual errors that need to be addressed due to the 'noise' of a faux error.

It was determined the fix coded should use a different editorial workflow filter, and this ticket was created in order to address that.

User Story or Problem Statement

Recently created and merged Q&A content view needs to be updated to use a different editorial workflow filter, per style guide.

https://prod.cms.va.gov/admin/structure/cm_document/note/124/views-style-guide

See this slack convo for context:
https://dsva.slack.com/archives/C52CL1PKQ/p1698437144686279

There is some urgency in prioritizing this as it will cause issues in the site when other work is merged e.g. it's holding up other PRs.

Acceptance Criteria

@chri5tia chri5tia added the Needs refining Issue status label Oct 27, 2023
@FranECross
Copy link

FranECross commented Oct 27, 2023

@chri5tia Approved to be worked on right away so as not to hold up other PRs or cause potential prod issues. Thank so much! cc @jilladams @swirtSJW

Reference ticket #15833

@jilladams
Copy link
Contributor

jilladams commented Nov 3, 2023

Outstanding PR feedback that we opted not to address in #15896 in order to unblock Facilities, but which does need to be addressed before this ticket closes. I'm noting what I see in PR and can't tell if it was already addressed. @chri5tia could you check boxes for anything that did already get handled?

  • Page specific Q&A view should move to /admin/content/audit/page-specific-qa and display a tab in alpha order
    • Local task only: checked
    • Local task link title: "Page-specific Q&A"
    • Local task parent: "content(content_audit_page)"
  • Content type column should be sortable

@chri5tia
Copy link
Contributor Author

chri5tia commented Nov 6, 2023

@jilladams all addressed in follow-up PR
#16003

@chri5tia
Copy link
Contributor Author

chri5tia commented Nov 7, 2023

Checked on prod and https://prod.cms.va.gov/admin/content/audit/qa doesn't load. I need to see what happened.

@jilladams jilladams assigned dsasser and unassigned chri5tia Nov 8, 2023
@jilladams
Copy link
Contributor

@dsasser noting since we're transitioning Christia's work to you:

She made a code change here to move this view from /admin/content/qa to /admin/content/audit/qa, but that still isn't true in prod. This is the last dangler she had from last sprint, so we'll need your help to sort out why.

@jilladams
Copy link
Contributor

This view did show up in the right path, so ticket is closed. I did notice, though, that the tab is not in alpha order. ( Poked around a little in https://github.com/department-of-veterans-affairs/va.gov-cms/blob/8c99f59a3bb1245e407385a177d619a71ee301d2/config/sync/views.view.content.yml to see if I could figure out how to rearrange it, but: no. Could not.) Is that easy to toss a fix up, or should I ticket?

@chri5tia
Copy link
Contributor Author

chri5tia commented Nov 9, 2023

It is because the weight of the menu tab option is set to -150 and that likely needs to be erased. Commenting because I checked my email and realized I didn't put that in here yesterday.

@dsasser
Copy link
Contributor

dsasser commented Nov 9, 2023

@jilladams

This view did show up in the right path, so ticket is closed. I did notice, though, that the tab is not in alpha order. ( Poked around a little in https://github.com/department-of-veterans-affairs/va.gov-cms/blob/8c99f59a3bb1245e407385a177d619a71ee301d2/config/sync/views.view.content.yml to see if I could figure out how to rearrange it, but: no. Could not.) Is that easy to toss a fix up, or should I ticket?

PR is up here: #16085

@jilladams
Copy link
Contributor

Verified in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Drupal engineering CMS team practice area Public Websites Scrum team in the Sitewide crew sitewide Unplanned work Work that was introduced post-planning
Projects
None yet
Development

No branches or pull requests

4 participants