VACMS-15798 / 15791 / 15795 next preview configs + oauth key handling #15936

tjheffner · 2023-10-31T23:18:30Z

Description

Closes #15798. Closes #15791. Closes #15795. Closes #15792.

This is the CMS-half of the work for the above tickets, the next-build specific work was done in: department-of-veterans-affairs/next-build#227. Certain values have been stored in AWS SSM & are made available through env vars set in the Tugboat UI settings.

With all of that in place, this PR can now be tested on CMS Tugboats.

Testing done

I tested locally with this companion PR: department-of-veterans-affairs/next-build#227

Visit any story page (ex: https://pr15936-r38pi1elxdywfriwbyojfsw3jhrw8kwk.ci.cms.va.gov/wilmington-health-care/stories/wilmington-va-has-highest-drug-take-back-in-eastern-market) and see that the editor experience is unchanged. You can check other content types too, but it is not necessary.

To confirm all of the underlying wiring is in place correctly: enabled Story and Story Listing as next site entities here: https://pr15936-r38pi1elxdywfriwbyojfsw3jhrw8kwk.ci.cms.va.gov/admin/config/services/next/entity-types

This configuration was purposely not committed to prevent next-build being used for preview until it is ready. A follow-up PR will include these configs + feature flag handling around preview, along with the correct UI (preview link vs iframe takeover).

After the entities are enabled, visit the story page (ex: https://pr15936-r38pi1elxdywfriwbyojfsw3jhrw8kwk.ci.cms.va.gov/wilmington-health-care/stories/wilmington-va-has-highest-drug-take-back-in-eastern-market) and check the view tab. There should be an iframe instead of the standard editor experience. It may take a moment to render, and will likely appear broken until vets-website assets are in place. This is expected.

Now edit that story with some changes and save it as a draft. There should now be a latest version tab. Click that (https://pr15936-r38pi1elxdywfriwbyojfsw3jhrw8kwk.ci.cms.va.gov/node/63185/latest) and see that the iframe exists, rendering the updated draft content.

Now create a new story with any data and save it unpublished. This content should also render in the iframe when looking at the View tab. (https://pr15936-r38pi1elxdywfriwbyojfsw3jhrw8kwk.ci.cms.va.gov/amarillo-health-care/stories/a-new-story)

You will also see logs from the running next server in the tugboat dashboard here:
https://tugboat.vfs.va.gov/654196858b633cb05e2b7869

Screenshots

Unchanged:

AFTER NEXT JS ENTITY IS ENABLED

Published:

Draft revision:

Draft never published:

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

The editor experience should be unchanged by default. Check this first.
After enabling next for specific content types (Story), these cases should be checked:
- Published
- Unpublished draft of previously published content
- New draft content (never published)

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

Bumps [datadog/dd-trace](https://github.com/DataDog/dd-trace-php) from 0.92.2 to 0.93.1. - [Release notes](https://github.com/DataDog/dd-trace-php/releases) - [Commits](DataDog/dd-trace-php@0.92.2...0.93.1) --- updated-dependencies: - dependency-name: datadog/dd-trace dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@swirtSJW

* VACMS-14342: Set up CODEOWNERS * h/t Dave * h/t Tanner * h/t Dave * Update .github/CODEOWNERS * Apply suggestions from code review h/t @swirtSJW

Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3377 to 0.0.3378. - [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases) - [Commits](department-of-veterans-affairs/content-build@v0.0.3377...v0.0.3378) --- updated-dependencies: - dependency-name: va-gov/content-build dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

#15927)

* VACMS-15276: Adds YouTube field * VACMS-15276: Adding field storage for YouTube

…Filter (#15896) * VACMS-15891: Update workflow filter to multiple * VACMS-15891: Updated the filter machine name too because Jill is smart. * VACMS-15891: Style-Guide-Related edits to view * VACMS-15891: Added section filter * VACMS-15891: Fix caption * VACMS-15891: Caption and tab * VACMS-15891: Copying new settings from view family * VACMS-15891: Fix pager back to 25 for cypress test

tjheffner · 2023-11-08T19:37:41Z

config/sync/next.next_site.next_build_preview_server.yml

+id: next_build_preview_server
+label: 'Next Build Preview Server'
+base_url: 'http://localhost:3000'
+preview_url: 'http://localhost:3000/api/preview'


noting these two urls work for local testing with next-build running separately outside of ddev.
these are overwritten in settings.tugboat.php

tjheffner · 2023-11-08T19:38:20Z

config/sync/simple_oauth.settings.yml

 token_cron_batch_size: 0
+public_key: ../public.key
+private_key: ../private.key


relative to docroot/

.tugboat/config.yml

tjheffner added 2 commits October 31, 2023 15:48

gitignore public/private key for oauth

3d6ac5c

export config for simple_oauth and next js site

5f10440

va-cms-bot temporarily deployed to Tugboat October 31, 2023 23:18 Destroyed

va-cms-bot had a problem deploying to Tugboat November 1, 2023 00:06 Error

use simple oauth for preview in next

78d8571

va-cms-bot temporarily deployed to Tugboat November 1, 2023 00:11 Destroyed

echo keys to files in tugboat

6723545

va-cms-bot temporarily deployed to Tugboat November 1, 2023 15:12 Destroyed

add other env vars where they need to be

383e2aa

va-cms-bot temporarily deployed to Tugboat November 1, 2023 17:04 Destroyed

This was referenced Nov 1, 2023

[DNM][SPIKE] VACMS-14419 next build preview #15166

Closed

VACMS-15791 next preview functionality department-of-veterans-affairs/next-build#227

Merged

jilladams and others added 9 commits November 2, 2023 14:21

[docs] Update and rename pw-dark-launch.md to dark-launch.md

6cc308b

VACMS-14342: Set up CODEOWNERS (#15581)

65d6b69

* VACMS-14342: Set up CODEOWNERS * h/t Dave * h/t Tanner * h/t Dave * Update .github/CODEOWNERS * Apply suggestions from code review h/t @swirtSJW

VACMS-15721: added description field for alert blocks view and browser (

26d508f

#15927)

VACMS-15276: Adds YouTube field (#15450)

faf0881

* VACMS-15276: Adds YouTube field * VACMS-15276: Adding field storage for YouTube

update perms for nextjs role

766efbb

update perms for nextjs role

ac52c8b

va-cms-bot temporarily deployed to Tugboat November 2, 2023 21:21 Destroyed

fix conflict

a281059

va-cms-bot had a problem deploying to Tugboat November 2, 2023 21:42 Error

re-export config for correct dependencies

c98fef7

va-cms-bot temporarily deployed to Tugboat November 2, 2023 21:50 Destroyed

va-cms-bot temporarily deployed to Tugboat November 7, 2023 18:51 Destroyed

override config for tugboat

4ab2ef2

va-cms-bot temporarily deployed to Tugboat November 7, 2023 21:30 Destroyed

include full domains in the url path...

5fa02a8

va-cms-bot temporarily deployed to Tugboat November 7, 2023 23:33 Destroyed

a couple more env vars in place

5d01d85

va-cms-bot temporarily deployed to Tugboat November 8, 2023 16:09 Destroyed

Merge branch 'main' into VACMS-15798-next-preview-configs

6bf5949

va-cms-bot temporarily deployed to Tugboat November 8, 2023 18:47 Destroyed

tjheffner commented Nov 8, 2023

View reviewed changes

env vars need added before build

051dce1

va-cms-bot temporarily deployed to Tugboat November 8, 2023 20:47 Destroyed

github-actions bot added Accelerated Publishing CMS Team CMS Product team that manages both editor exp and devops labels Nov 8, 2023

tweak env vars slightly

609901e

va-cms-bot temporarily deployed to Tugboat November 8, 2023 23:00 Destroyed

ndouglas reviewed Nov 9, 2023

View reviewed changes

.tugboat/config.yml Outdated Show resolved Hide resolved

.tugboat/config.yml Outdated Show resolved Hide resolved

quote env vars

5baf0f3

va-cms-bot temporarily deployed to Tugboat November 9, 2023 02:10 Destroyed

tjheffner marked this pull request as ready for review November 9, 2023 04:57

tjheffner requested review from a team as code owners November 9, 2023 04:57

ndouglas approved these changes Nov 9, 2023

View reviewed changes

tjheffner merged commit ba007a6 into main Nov 9, 2023
16 checks passed

tjheffner deleted the VACMS-15798-next-preview-configs branch November 9, 2023 15:42

This was referenced Nov 9, 2023

Add envs vars for next-build to all tugboat envs #16078

Closed

Next-build server running per Tugboat environment #10068

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS-15798 / 15791 / 15795 next preview configs + oauth key handling #15936

VACMS-15798 / 15791 / 15795 next preview configs + oauth key handling #15936

tjheffner commented Oct 31, 2023 •

edited

Loading

tjheffner Nov 8, 2023

tjheffner Nov 8, 2023

VACMS-15798 / 15791 / 15795 next preview configs + oauth key handling #15936

VACMS-15798 / 15791 / 15795 next preview configs + oauth key handling #15936

Conversation

tjheffner commented Oct 31, 2023 • edited Loading

Description

Testing done

Screenshots

QA steps

Definition of Done

Select Team for PR review

tjheffner Nov 8, 2023

Choose a reason for hiding this comment

tjheffner Nov 8, 2023

Choose a reason for hiding this comment

tjheffner commented Oct 31, 2023 •

edited

Loading