Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM][SPIKE] VACMS-14419 next build preview #15166

Closed
wants to merge 3 commits into from

Conversation

tjheffner
Copy link
Contributor

Description

Relates to #14419. (or closes?)

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 8, 2023 20:46 Destroyed
@tjheffner tjheffner mentioned this pull request Sep 8, 2023
9 tasks
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@ndouglas ndouglas marked this pull request as draft September 27, 2023 16:18
@ndouglas
Copy link
Contributor

Please keep the PR in draft rather than using the labels, just to prevent misclicks/misreading labels, etc 🙂

@tjheffner
Copy link
Contributor Author

Apologies, will do so in the future! Thanks for swapping this to draft 😄

@tjheffner
Copy link
Contributor Author

Closing this in favor of #15936

@tjheffner tjheffner closed this Nov 1, 2023
@tjheffner tjheffner deleted the VACMS-14419-next-build-preview-spike branch November 1, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants